Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp686233ybx; Tue, 5 Nov 2019 04:03:28 -0800 (PST) X-Google-Smtp-Source: APXvYqx1ZbxUAbW/KtlJ+AFiQDxJU0pdLGrqioEMXP9wWNka0uWxe5eMcswyHtrAufhSupAG9wd6 X-Received: by 2002:a17:906:f42:: with SMTP id h2mr28834948ejj.39.1572955408275; Tue, 05 Nov 2019 04:03:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572955408; cv=none; d=google.com; s=arc-20160816; b=GL+2Q2BuKqa3sYvx6GvV2sPkwRwa/keaIaPpRNb0lPSeGzzVTBumcEBBFqdSsLbTO4 DRoRhV0aVcuv2cFPPXxlGfCQNrIxdY4T1iaLtzHo/KBRJzLehIs4znUeTVF4rSK/NBxO FkuE2MhJ4q6oQCWnftI5yoUnWVvQYPR7vmWd85AqoX3v6y+mwGfdXlFVKrNOFJ2/Po1H THYZPPfQEc34QPwdGmpvSSpEuz68aIjrFUgg4ie4wp65WUTbexFAt75Q0gmmDycrEiDH HrLFULLeqV853tsxMGh8xykdCSovUyY8VtncNOA4WOrk6CEhXL9bNClWNsFbAkIR2qYL ZCzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Ao1rlHcLUQ5Y1RuA5Fm1CjTs0sc8ov2JwdhgeIweKhc=; b=ZzII+UBqt7sxIQaYWP0xZWDCMGv3Zcz53EK/Ipiny1pqPVlii+QCxm++VWkBN1XlYd oEWbhsKWI0JH1IDQTU2XQcYbQs7mB/DoDqT6fypWZMyeHbgq/fESiEE+e8l1IcIK8AY+ 2ullhzebRouUqtr2wKjfiZtGOn1cnWLwH0RjC3TtG7l4C7Vb62EuDC8FINuSExBSU+My KuD19FiG3nBDRRueREXDXYhp50KHRtTx9KSQjKRz2bfgRwwLgHMPacbt7KCseYheGZEz oxHH6hGV45NXW5DrYy+bOK28MC2SQaXnqV6sA1RUqhZcqu7VrbAjB5pDFc+Uvuujo0sy 3a8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mbobrowski-org.20150623.gappssmtp.com header.s=20150623 header.b=JliYhNuw; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q20si3122174eja.339.2019.11.05.04.02.36; Tue, 05 Nov 2019 04:03:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@mbobrowski-org.20150623.gappssmtp.com header.s=20150623 header.b=JliYhNuw; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730848AbfKEMCC (ORCPT + 99 others); Tue, 5 Nov 2019 07:02:02 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:41521 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730816AbfKEMCB (ORCPT ); Tue, 5 Nov 2019 07:02:01 -0500 Received: by mail-pg1-f193.google.com with SMTP id l3so13981433pgr.8 for ; Tue, 05 Nov 2019 04:02:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ao1rlHcLUQ5Y1RuA5Fm1CjTs0sc8ov2JwdhgeIweKhc=; b=JliYhNuwH4T7aq/teXHCcWlm4i9B7mYbqlSRgvnvEXFSL3wUteMYgpGT2V7gDb++Fl N2V0IStiqPhLo8WwElLO3H/LedZNCreosAOfUrA+20VFGeu/3vuOu3OfEdYf+nVWSVsR BzL3FUoF2CJMtfBKPcZ3WKlQ2+N45IH1cKJvETefpF7As9QSmfWTUD3Gq2UiQCCEDVJ/ xhoR0P+8PCkRD3Bwxfk3VljEhXW5PwvNLqNG0XWUlJEC2Q0FMaA2k89JZzOrumC5LwSO 8DXYHDAhj22BuJNqA7BDtfQu7N3KYKvP+r+HhX8JIjYd/nvev5Ad0utpM1yYaUSr1Gv1 N+YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ao1rlHcLUQ5Y1RuA5Fm1CjTs0sc8ov2JwdhgeIweKhc=; b=UuuE4LMETx3LAl9uFIE21XNDxBszsDwHidt9xnkJm1436iRj/wgd2x8FLfvyljTYye g0bmQJsv9Z9UDk9GKQDiSUhE8Pfw7QpKvs9vTg/xZ6J4wT3yEU4S0wCadhxq3j4zuXwH AQ7PveL6JAXzPSIy8hvKrw6EBrKN5lsLo58I2liYgACjpDi6Py+JS8bW7InNPksh95qt kGkrJc0gqkXYAAs6dzUFCQC+JSL7gKxcv6bvw6xzkkJX6GBNDcKYltRjp05I2N+BdmhJ ndlMA1KgHLXjjxXODLPymY+128qztXiexc2eRh4ZR9tOFOnd4RBwkDdIVigA86sN6yAl 8wJQ== X-Gm-Message-State: APjAAAXMnqctdyVQEtHpu1jAtp6+sG7CSY46eTeStbrJgR8rHdiLgESH zybTOYopq1odTIod3gFHVpIXb9E9Iw== X-Received: by 2002:a63:67c3:: with SMTP id b186mr36117014pgc.152.1572955320145; Tue, 05 Nov 2019 04:02:00 -0800 (PST) Received: from poseidon.bobrowski.net ([114.78.226.167]) by smtp.gmail.com with ESMTPSA id z23sm7311835pgj.43.2019.11.05.04.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 04:01:58 -0800 (PST) Date: Tue, 5 Nov 2019 23:01:51 +1100 From: Matthew Bobrowski To: tytso@mit.edu, jack@suse.cz, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, riteshh@linux.ibm.com Subject: [PATCH v7 08/11] ext4: move inode extension/truncate code out from ->iomap_end() callback Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org In preparation for implementing the iomap direct I/O modifications, the inode extension/truncate code needs to be moved out from the ext4_iomap_end() callback. For direct I/O, if the current code remained, it would behave incorrrectly. Updating the inode size prior to converting unwritten extents would potentially allow a racing direct I/O read to find unwritten extents before being converted correctly. The inode extension/truncate code now resides within a new helper ext4_handle_inode_extension(). This function has been designed so that it can accommodate for both DAX and direct I/O extension/truncate operations. Signed-off-by: Matthew Bobrowski Reviewed-by: Jan Kara Reviewed-by: Ritesh Harjani --- fs/ext4/file.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++++- fs/ext4/inode.c | 48 +------------------------- 2 files changed, 89 insertions(+), 48 deletions(-) diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 440f4c6ba4ee..ec54fec96a81 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -33,6 +33,7 @@ #include "ext4_jbd2.h" #include "xattr.h" #include "acl.h" +#include "truncate.h" static bool ext4_dio_supported(struct inode *inode) { @@ -234,12 +235,95 @@ static ssize_t ext4_write_checks(struct kiocb *iocb, struct iov_iter *from) return iov_iter_count(from); } +static ssize_t ext4_handle_inode_extension(struct inode *inode, loff_t offset, + ssize_t written, size_t count) +{ + handle_t *handle; + bool truncate = false; + u8 blkbits = inode->i_blkbits; + ext4_lblk_t written_blk, end_blk; + + /* + * Note that EXT4_I(inode)->i_disksize can get extended up to + * inode->i_size while the I/O was running due to writeback of delalloc + * blocks. But, the code in ext4_iomap_alloc() is careful to use + * zeroed/unwritten extents if this is possible; thus we won't leave + * uninitialized blocks in a file even if we didn't succeed in writing + * as much as we intended. + */ + WARN_ON_ONCE(i_size_read(inode) < EXT4_I(inode)->i_disksize); + if (offset + count <= EXT4_I(inode)->i_disksize) { + /* + * We need to ensure that the inode is removed from the orphan + * list if it has been added prematurely, due to writeback of + * delalloc blocks. + */ + if (!list_empty(&EXT4_I(inode)->i_orphan) && inode->i_nlink) { + handle = ext4_journal_start(inode, EXT4_HT_INODE, 2); + + if (IS_ERR(handle)) { + ext4_orphan_del(NULL, inode); + return PTR_ERR(handle); + } + + ext4_orphan_del(handle, inode); + ext4_journal_stop(handle); + } + + return written; + } + + if (written < 0) + goto truncate; + + handle = ext4_journal_start(inode, EXT4_HT_INODE, 2); + if (IS_ERR(handle)) { + written = PTR_ERR(handle); + goto truncate; + } + + if (ext4_update_inode_size(inode, offset + written)) + ext4_mark_inode_dirty(handle, inode); + + /* + * We may need to truncate allocated but not written blocks beyond EOF. + */ + written_blk = ALIGN(offset + written, 1 << blkbits); + end_blk = ALIGN(offset + count, 1 << blkbits); + if (written_blk < end_blk && ext4_can_truncate(inode)) + truncate = true; + + /* + * Remove the inode from the orphan list if it has been extended and + * everything went OK. + */ + if (!truncate && inode->i_nlink) + ext4_orphan_del(handle, inode); + ext4_journal_stop(handle); + + if (truncate) { +truncate: + ext4_truncate_failed_write(inode); + /* + * If the truncate operation failed early, then the inode may + * still be on the orphan list. In that case, we need to try + * remove the inode from the in-memory linked list. + */ + if (inode->i_nlink) + ext4_orphan_del(NULL, inode); + } + + return written; +} + #ifdef CONFIG_FS_DAX static ssize_t ext4_dax_write_iter(struct kiocb *iocb, struct iov_iter *from) { - struct inode *inode = file_inode(iocb->ki_filp); ssize_t ret; + size_t count; + loff_t offset; + struct inode *inode = file_inode(iocb->ki_filp); if (!inode_trylock(inode)) { if (iocb->ki_flags & IOCB_NOWAIT) @@ -256,7 +340,10 @@ ext4_dax_write_iter(struct kiocb *iocb, struct iov_iter *from) if (ret) goto out; + offset = iocb->ki_pos; + count = iov_iter_count(from); ret = dax_iomap_rw(iocb, from, &ext4_iomap_ops); + ret = ext4_handle_inode_extension(inode, offset, ret, count); out: inode_unlock(inode); if (ret > 0) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 9bd80df6b856..071a1f976aab 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3583,53 +3583,7 @@ static int ext4_iomap_begin(struct inode *inode, loff_t offset, loff_t length, static int ext4_iomap_end(struct inode *inode, loff_t offset, loff_t length, ssize_t written, unsigned flags, struct iomap *iomap) { - int ret = 0; - handle_t *handle; - int blkbits = inode->i_blkbits; - bool truncate = false; - - if (!(flags & IOMAP_WRITE) || (flags & IOMAP_FAULT)) - return 0; - - handle = ext4_journal_start(inode, EXT4_HT_INODE, 2); - if (IS_ERR(handle)) { - ret = PTR_ERR(handle); - goto orphan_del; - } - if (ext4_update_inode_size(inode, offset + written)) - ext4_mark_inode_dirty(handle, inode); - /* - * We may need to truncate allocated but not written blocks beyond EOF. - */ - if (iomap->offset + iomap->length > - ALIGN(inode->i_size, 1 << blkbits)) { - ext4_lblk_t written_blk, end_blk; - - written_blk = (offset + written) >> blkbits; - end_blk = (offset + length) >> blkbits; - if (written_blk < end_blk && ext4_can_truncate(inode)) - truncate = true; - } - /* - * Remove inode from orphan list if we were extending a inode and - * everything went fine. - */ - if (!truncate && inode->i_nlink && - !list_empty(&EXT4_I(inode)->i_orphan)) - ext4_orphan_del(handle, inode); - ext4_journal_stop(handle); - if (truncate) { - ext4_truncate_failed_write(inode); -orphan_del: - /* - * If truncate failed early the inode might still be on the - * orphan list; we need to make sure the inode is removed from - * the orphan list in that case. - */ - if (inode->i_nlink) - ext4_orphan_del(NULL, inode); - } - return ret; + return 0; } const struct iomap_ops ext4_iomap_ops = { -- 2.20.1