Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 06 Nov 2019 18:52:07 +0800
From:   Chengguang Xu <cgxu519@mykernel.net>
Reply-To: cgxu519@mykernel.net
To:     "Darrick J. Wong" <darrick.wong@oracle.com>
Cc:     "Jan Kara" <jack@suse.cz>,
        "adilger.kernel" <adilger.kernel@dilger.ca>,
        "tytso" <tytso@mit.edu>, "Jan Kara" <jack@suse.com>,
        "linux-ext4" <linux-ext4@vger.kernel.org>
Message-ID: <16e4057d1d7.11b9fb039554.6579544170413347739@mykernel.net>
In-Reply-To: <16e3fd9bbd0.13ef078cc303.945603942066109125@mykernel.net>
References: <20191015102327.5333-1-cgxu519@mykernel.net>
 <20191015112523.GB29554@quack2.suse.cz>
 <16e3f00ed3d.da5d5acd1285.2289879597060795256@mykernel.net> <20191106050336.GD15203@magnolia> <16e3fd9bbd0.13ef078cc303.945603942066109125@mykernel.net>
Subject: Re: [PATCH v2] ext4: choose hardlimit when softlimit is larger than
 hardlimit in ext4_statfs_project()
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: ZohoCN Mail
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

 ---- =E5=9C=A8 =E6=98=9F=E6=9C=9F=E4=B8=89, 2019-11-06 16:34:24 Chengguang=
 Xu <cgxu519@mykernel.net> =E6=92=B0=E5=86=99 ----
 >  ---- =E5=9C=A8 =E6=98=9F=E6=9C=9F=E4=B8=89, 2019-11-06 13:03:36 Darrick=
 J. Wong <darrick.wong@oracle.com> =E6=92=B0=E5=86=99 ----
 >  > On Wed, Nov 06, 2019 at 12:37:35PM +0800, Chengguang Xu wrote:
 >  > >  ---- =E5=9C=A8 =E6=98=9F=E6=9C=9F=E4=BA=8C, 2019-10-15 19:25:23 Ja=
n Kara <jack@suse.cz> =E6=92=B0=E5=86=99 ----
 >  > >  > On Tue 15-10-19 18:23:27, Chengguang Xu wrote:
 >  > >  > > Setting softlimit larger than hardlimit seems meaningless
 >  > >  > > for disk quota but currently it is allowed. In this case,
 >  > >  > > there may be a bit of comfusion for users when they run
 >  > >  > > df comamnd to directory which has project quota.
 >  > >  > >=20
 >  > >  > > For example, we set 20M softlimit and 10M hardlimit of
 >  > >  > > block usage limit for project quota of test_dir(project id 123=
).
 >  > >  > >=20
 >  > >  > > [root@hades mnt_ext4]# repquota -P -a
 >  > >  > > *** Report for project quotas on device /dev/loop0
 >  > >  > > Block grace time: 7days; Inode grace time: 7days
 >  > >  > >                         Block limits                File limit=
s
 >  > >  > > Project         used    soft    hard  grace    used  soft  har=
d  grace
 >  > >  > > --------------------------------------------------------------=
--------
 >  > >  > >  0        --      13       0       0              2     0     =
0
 >  > >  > >  123      --   10237   20480   10240              5   200   10=
0
 >  > >  > >=20
 >  > >  > > The result of df command as below:
 >  > >  > >=20
 >  > >  > > [root@hades mnt_ext4]# df -h test_dir
 >  > >  > > Filesystem      Size  Used Avail Use% Mounted on
 >  > >  > > /dev/loop0       20M   10M   10M  50% /home/cgxu/test/mnt_ext4
 >  > >  > >=20
 >  > >  > > Even though it looks like there is another 10M free space to u=
se,
 >  > >  > > if we write new data to diretory test_dir(inherit project id),
 >  > >  > > the write will fail with errno(-EDQUOT).
 >  > >  > >=20
 >  > >  > > After this patch, the df result looks like below.
 >  > >  > >=20
 >  > >  > > [root@hades mnt_ext4]# df -h test_dir
 >  > >  > > Filesystem      Size  Used Avail Use% Mounted on
 >  > >  > > /dev/loop0       10M   10M  3.0K 100% /home/cgxu/test/mnt_ext4
 >  > >  > >=20
 >  > >  > > Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
 >  > >  > > ---
 >  > >  > > - Fix a bug in the limit setting logic.
 >  > >  >=20
 >  > >  > Thanks for the patch! It looks good to me. You can add:
 >  > >  >=20
 >  > >  > Reviewed-by: Jan Kara <jack@suse.cz>
 >  > >  >=20
 >  > >=20
 >  > > Hi Jan,
 >  > >=20
 >  > > I have a proposal for another direction.
 >  > > Could we add a check for soft limit  in quota layer when setting th=
e value?
 >  > > So that we could not bother with  specific file systems on statfs()=
.=20
 >  >=20
 >  > How do the other filesystems (e.g. xfs) behave if someone tries to se=
t a
 >  > soft limit higher than the hard limit?
 >  >=20
 >=20
 > In xfs if (hard && hard < soft), the limit will not be set(or changed) b=
ut command xfs_quota does not return error.
 >=20

Hi Darrick,

IMO, set nothing and return success seems  not reasonable,=20
is it possible change to set softlimit to hardlimit when softlimit > hardli=
mit?

Thanks,
Chengguang