Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 07 Nov 2019 10:54:43 +0800
From:   Chengguang Xu <cgxu519@mykernel.net>
Reply-To: cgxu519@mykernel.net
To:     "Jan Kara" <jack@suse.cz>
Cc:     "jack" <jack@suse.com>, "linux-ext4" <linux-ext4@vger.kernel.org>
Message-ID: <16e43c91b4e.12c0f5d17918.413402503051848643@mykernel.net>
In-Reply-To: <20191106154236.GB12685@quack2.suse.cz>
References: <20191104114036.9893-1-cgxu519@mykernel.net>
 <20191104114036.9893-2-cgxu519@mykernel.net> <20191106154236.GB12685@quack2.suse.cz>
Subject: Re: [PATCH 2/5] ext2: code cleanup by calling
 ext2_group_last_block_no()
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: ZohoCN Mail
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

 ---- =E5=9C=A8 =E6=98=9F=E6=9C=9F=E4=B8=89, 2019-11-06 23:42:36 Jan Kara <=
jack@suse.cz> =E6=92=B0=E5=86=99 ----
 > On Mon 04-11-19 19:40:33, Chengguang Xu wrote:
 > > Call common helper ext2_group_last_block_no() to
 > > calculate group last block number.
 > >=20
 > > Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
 >=20
 > Thanks for the patch! I've applied it (as well as 1/5) and added attache=
d
 > simplification on top.
 >=20

In ext2_try_to_allocate()

+=09=09if (my_rsv->_rsv_end < group_last_block)
+=09=09=09end =3D my_rsv->_rsv_end - group_first_block + 1;
+=09=09if (grp_goal < start || grp_goal > end)

Based on original code, shouldn't it be  if (grp_goal < start || grp_goal >=
=3Dend) ?

Thanks,
Chengguang