Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp379957ybx; Wed, 6 Nov 2019 18:58:46 -0800 (PST) X-Google-Smtp-Source: APXvYqzZJfw5f8mp1XEoj45PjrzBeVN3XddTmlmgV4QwVyxn3OkIKX4mM1jfLpncuxskfEJ+8y/L X-Received: by 2002:aa7:d888:: with SMTP id u8mr1150734edq.144.1573095526096; Wed, 06 Nov 2019 18:58:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1573095526; cv=pass; d=google.com; s=arc-20160816; b=vv8wupEMInOkFzWqooymOOjQntdHBGg2wGOtCIlHeoBVZG9ebRqm2zOH8L8QSv14Kb h9IxUFYZPV1T6tJksgL7XmMrFQTrrwPfk+j7+Fh01BkC531SaUqUq2I1CLd8sI13n908 vcCV2nFFj1lcNzKcpIB/mh6v6xvz5xclp2wHH4K3Er7qo/Pwkg2iDwmFDma3VNERYgcb O5oFmKt+29ZI5phIqLk0FEHIsxzUumdzqdJrUl72MUSk1X0CQqoxNuLihvobdo9EizJq Xf+CkbgbQ5Nrgy/rzlTo9wdXVWlSvdnszm19AMrlRRXwRrYdf6t5LkP6K6Vpf/Rbc9+p lblA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-transfer-encoding :mime-version:subject:references:in-reply-to:message-id:cc:to :reply-to:from:date:dkim-signature; bh=N+1w3mItBQ0eGakspfilaXJr2gCo3j9+9ebN6nqI+Ek=; b=JwKaSCrAAyQvouiq4T7W3nx/Ocary0jBTLMPArQ21kV6n7JTXp+1DYpIYsoK5hqIKO ckZy+AG1lBDiDnNPq5HJbFekqc8g7nhR2RUqRQExN8wO+bxZPbizu8xCmZqEa7xLRao1 kVlEAUNFdKtM+uhDk+nfhaoSEGLZLWY4S04+h398PUtn9HEWaeDP3I8yOruO/ghHCB2W bqE9hGjB3TOmm7jKv/Sm+Ck+R586iMNe8eG3G7VQKL/Epsl7zcUd8dh4RW+cuImSkUMV ZCDl9AAarpWbfdagZzQaNZUGfTYwO3tCYDSxBX825r925/xYA5Tiuq/xDfyMhAUBkw2g 5Snw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mykernel.net header.s=zohomail header.b=dWmd4T89; arc=pass (i=1 spf=pass spfdomain=mykernel.net dkim=pass dkdomain=mykernel.net dmarc=pass fromdomain=mykernel.net>); spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g24si426208edv.239.2019.11.06.18.58.20; Wed, 06 Nov 2019 18:58:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@mykernel.net header.s=zohomail header.b=dWmd4T89; arc=pass (i=1 spf=pass spfdomain=mykernel.net dkim=pass dkdomain=mykernel.net dmarc=pass fromdomain=mykernel.net>); spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732771AbfKGC6Q (ORCPT + 99 others); Wed, 6 Nov 2019 21:58:16 -0500 Received: from sender2-pp-o92.zoho.com.cn ([163.53.93.251]:25363 "EHLO sender3-pp-o92.zoho.com.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727665AbfKGC6Q (ORCPT ); Wed, 6 Nov 2019 21:58:16 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1573095484; cv=none; d=zoho.com.cn; s=zohoarc; b=PSeZBo52JhXncvyKYXlpwPfdwfzrm9P/5h6vUUmmV9Sz2Q4Ds0vEMxFIyiKAUPZmNZEvsBF0ypFn11GJtLfPBTHF6pgRNTdlRzo0yvhWQElVOQ/bw2kSOKl3VKjrlS9GZtoLdl1bcM/ty8d9wgHNxn1oKq/sIhXPQv2wQpwJE3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com.cn; s=zohoarc; t=1573095484; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:Reply-To:References:Subject:To; bh=N+1w3mItBQ0eGakspfilaXJr2gCo3j9+9ebN6nqI+Ek=; b=AHMeRedcXCn7DA3QTcqqcYq2Y81iILGW9/Siqx0AMUDGculS8mhBKmtVVkhoFcCqmirQnxqgJZPG/WwQ7jx8XuqGsA2y3HxXrq8xig1jalmvni+devR9ge2BpUyXr50ctmlZthRb3/sULUsGBeTxHyMQn/66Tt0vgc5wL9FANQg= ARC-Authentication-Results: i=1; mx.zoho.com.cn; dkim=pass header.i=mykernel.net; spf=pass smtp.mailfrom=cgxu519@mykernel.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1573095484; s=zohomail; d=mykernel.net; i=cgxu519@mykernel.net; h=Date:From:Reply-To:To:Cc:Message-ID:In-Reply-To:References:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding; l=536; bh=N+1w3mItBQ0eGakspfilaXJr2gCo3j9+9ebN6nqI+Ek=; b=dWmd4T89qWdP4Uqghuhlh0rg9nWy9NPbyyenfaEiM9ftbMIDAxQj0yE0m2FmeaFJ +h2z5xygLHfejnl0n2vdRDwD6UmXJGmEynOwdFxadvWPsypFm0h7Jc1iI8hFjdCjHB0 jip7LBMFJjQS2eDwwxBQnSpQX6TMXee5vFcsk0gc= Received: from mail.baihui.com by mx.zoho.com.cn with SMTP id 157309548317966.63134305884375; Thu, 7 Nov 2019 10:58:03 +0800 (CST) Date: Thu, 07 Nov 2019 10:58:03 +0800 From: Chengguang Xu Reply-To: cgxu519@mykernel.net To: "Jan Kara" Cc: "jack" , "linux-ext4" Message-ID: <16e43cc2728.de6ac2bc928.3996069392231034746@mykernel.net> In-Reply-To: <20191106155900.GC12685@quack2.suse.cz> References: <20191104114036.9893-1-cgxu519@mykernel.net> <20191104114036.9893-4-cgxu519@mykernel.net> <20191106155900.GC12685@quack2.suse.cz> Subject: Re: [PATCH 4/5] ext2: code cleanup for ext2_try_to_allocate() MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Priority: Medium User-Agent: ZohoCN Mail X-Mailer: ZohoCN Mail Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org ---- =E5=9C=A8 =E6=98=9F=E6=9C=9F=E4=B8=89, 2019-11-06 23:59:00 Jan Kara <= jack@suse.cz> =E6=92=B0=E5=86=99 ---- > On Mon 04-11-19 19:40:35, Chengguang Xu wrote: > > Code cleanup by removing duplicated code. > >=20 > > Signed-off-by: Chengguang Xu >=20 > Thanks for the patch! I've merged it with a small update to switch the > while() loop into a for() loop which is somewhat more natural in that > situation. Resulting patch attached. >=20 Looks fine to me.=20 Thanks, Chengguang