Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp6527133ybx; Mon, 11 Nov 2019 10:25:13 -0800 (PST) X-Google-Smtp-Source: APXvYqyeItiqnFpGi8lbKEsETC69UauiquzKZhRiDEwahxjSlHIUHb55xPYGzwl0Ml1iinXeyyQ2 X-Received: by 2002:a50:e8c2:: with SMTP id l2mr27747208edn.78.1573496713082; Mon, 11 Nov 2019 10:25:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573496713; cv=none; d=google.com; s=arc-20160816; b=cGjMX1xtvFKlFci40YVFweesY/IrPldCbpNap6barZvZ3r0O42gKsKu0UiESOYt6so D9kwMrqMP4EUUZooRWHzRY10Va0b63HNv8xHuvZyBC6Qa5RAKHj8rzvgDkw7SkViFJAO UdKdr1Ho9m3NLc24YXqxB7H6T22aNt7RSeTtLgQDRcJD7zNkst2ZDaIqqqv2TZPPjhNz vF2y70giFOOgytmevQt1qEoAq4NXDgxHVQUcdxWSxDPT3aRBdOLVZ984w1Pbn9ONWsr5 AfeEz5XmdG7Q5f4eENe1wzXk06idKN+AdjGDmfRpPzYcZiYPLwknCsIWemZQamco7O89 m+bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=zSR5xdY2oIX93Yxm6OEE+3MvxK3PMku6AbskHvgHoYg=; b=ai4fSz4NlcRGfeHON8k7jCSXptAiNrB5Wnc+s0HmXDUdgBHvQ9dTD0JijAZcphn81S DqoNYLf+D+r5xrDw7sCzdhyq7uNTUg5FQacMm7aP10NGPwbscrVocJWwf7Sn1Fscq0xa E1QI7HGh14UTvKY82BhzodJt3opMpKP9ROzcyTGwQLyEhJFxN6ImoHIZTd6tyjNaRqrl B+Pa+JakUkqNH2rKS7+4T+dE0M5Sy3626r3emOd/FF+4Wh81Vm6DQUUBz8339gny7dmP qrJhlV5QhK7/QQAu99GkQ8wWJmFOBbyqKIoWis3LqQNa+PgeWn3tQSWcx3bWG6XTiML3 m3+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b34si11906768edc.74.2019.11.11.10.24.42; Mon, 11 Nov 2019 10:25:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbfKKSY2 (ORCPT + 99 others); Mon, 11 Nov 2019 13:24:28 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:55736 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726821AbfKKSY2 (ORCPT ); Mon, 11 Nov 2019 13:24:28 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-98.corp.google.com [104.133.0.98] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xABIOH6Y022708 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Nov 2019 13:24:18 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 16C0A4202FD; Mon, 11 Nov 2019 13:24:17 -0500 (EST) Date: Mon, 11 Nov 2019 13:24:17 -0500 From: "Theodore Y. Ts'o" To: Ritesh Harjani Cc: syzbot , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Jan Kara Subject: Re: general protection fault in ext4_writepages Message-ID: <20191111182417.GB5165@mit.edu> References: <00000000000073d3a70597069799@google.com> <20191111051236.2717D11C05B@d06av25.portsmouth.uk.ibm.com> <20191111053231.F129B11C04C@d06av25.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191111053231.F129B11C04C@d06av25.portsmouth.uk.ibm.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Nov 11, 2019 at 11:02:31AM +0530, Ritesh Harjani wrote: > > Updating the link. > > On 11/11/19 10:42 AM, Ritesh Harjani wrote: > > Hello Ted, > > > > This issue seems to be coming via fault injection failure in slab > > allocation. This should be fixed via below patch on your latest ext4 > > branch. > > > > https://marc.info/?l=linux-ext4&m=804&w=2 > https://marc.info/?l=linux-ext4&m=157303310723804&w=2 Agreed, although unfortunately I wasn't able to make the reproducer cause a failure _without_ the patch. Perhaps something other than enabling FAILSLAB and KASAN was needed? #syz test https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git test Let's see if the Syzbot can confirm that the patch addresses the problem. - Ted