Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp6753448ybx; Mon, 11 Nov 2019 14:12:23 -0800 (PST) X-Google-Smtp-Source: APXvYqxHOPAPtblyjekDsGytrfNDI1N9qm4Pbo+LbHt6+iT63hmqEY7Ktj4+RmiMnaO0AMsAEzX7 X-Received: by 2002:a17:907:1114:: with SMTP id qu20mr25875457ejb.42.1573510343138; Mon, 11 Nov 2019 14:12:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573510343; cv=none; d=google.com; s=arc-20160816; b=a04PJohQfQw4wsFCT9lJ83FaBpo2CJKDfVa1ZkJ4UXBt05/KRshXfrEPFK03CRFfmB GUe4AQgLzlhDgaX5YKrGYpzs0FM7Pj6nRDoH0625QTsOfKeNrh+rfI1+q3u4U9f0MPF2 K5dELGsz2EO3jQmAfaxcWFR+l34FPyzxQvTmlA54XY6jVrf4kY7XqHCvK/+8aNf+nEkX dxBrQHTMhUHGuQdKvOqXhq4mFaNserbz986p0LbnomZnnRr9I5mqM9g1pz8NGJ/ivuvV X1Qb94Z5n9tBZ0jwnFsnmWdHTUI1rdtV7brXb0wIhYbS7bSXDHms3ugWcQS0SnDaPMez BMuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=555VczsFU6Dr94WZuZwsdxmHouJLIaWV/o0lIsMzOi0=; b=oybku6UFeB8VCLpY1ShXjceLdE4d6+aP7pmG9/w0Qb3DFbSc8EZqBEtulbb1X0gE5T heVK7f0gut/zm7T7jXrKBsFvjgn+2O47ZPpBmUtKn6DscmOU6FHChF/9SqCurZH7TdUG G7EvgGy8nlJYsNTPkKK1gh1WhYcowS+MeOYGL9IyrHGlLzvXAErRdOPNNC5rS7DAGgAo 8LEZedohkir4uE7ed3MLYhi9keKeuY+FeEIhb29Stjo7EvMx7bO4cX/gnF/E5Dq8I2V1 4fNLVhKvJ0cbYpqHgQeNNhuHA9EEs2H9bN8ZY5McL/Nnjlb+gq2uUIDDF5ArLYpr6+Et teiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l40si12170065edb.432.2019.11.11.14.11.50; Mon, 11 Nov 2019 14:12:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726912AbfKKWLq (ORCPT + 99 others); Mon, 11 Nov 2019 17:11:46 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:44912 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726845AbfKKWLq (ORCPT ); Mon, 11 Nov 2019 17:11:46 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-98.corp.google.com [104.133.0.98] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xABMBSbm023762 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Nov 2019 17:11:29 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 785494202FD; Mon, 11 Nov 2019 17:11:28 -0500 (EST) Date: Mon, 11 Nov 2019 17:11:28 -0500 From: "Theodore Y. Ts'o" To: Ritesh Harjani Cc: dan.carpenter@oracle.com, jack@suse.cz, linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/1] ext4: Add error handling for io_end_vec struct allocation Message-ID: <20191111221128.GA23273@mit.edu> References: <20191106082505.GA31923@mwanda> <20191106093809.10673-1-riteshh@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191106093809.10673-1-riteshh@linux.ibm.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Nov 06, 2019 at 03:08:09PM +0530, Ritesh Harjani wrote: > This patch adds the error handling in case of any memory allocation > failure for io_end_vec. This was missing in original > patch series which enables dioread_nolock for blocksize < pagesize. > > Fixes: c8cc88163f40 ("ext4: Add support for blocksize < pagesize in dioread_nolock") > Reported-by: Dan Carpenter > Signed-off-by: Ritesh Harjani Applied, thanks. - Ted