Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4001648ybc; Thu, 14 Nov 2019 19:17:12 -0800 (PST) X-Google-Smtp-Source: APXvYqwHx1b0Aq4uEpAp1RMSx31eFh3URL4cjUN/hdCYxj2uwYozVM4Y0+Olv73lSkk/yfQmx+07 X-Received: by 2002:a17:906:3ec8:: with SMTP id d8mr10521267ejj.55.1573787832045; Thu, 14 Nov 2019 19:17:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573787832; cv=none; d=google.com; s=arc-20160816; b=FDC6Exl5sOu2XpRq1vCBB/HO/yn9o97rMC0tYHflRLkQkB5lHIOBTOD+x0OGLhHYAn HMjAslqCijUbYpDXXRwFsTh5NsqkRRWX8dhd2kPJ4fQptWIbTVDH7xrfGVf99z6vDhAI Dy+0WV4X9GBwNrqxg+32kmVILjn19mhMAq7sYp8kKpsc93ECeIIM6K2od8XKkRkcJ4So vYWx2SDzMkUM6/ssoQiG4mlgPCrZ0tXICM43qUOHbS7THA15eXg637JLz1O1cyyDHTAV W7CrNftRRWasAVmBR3moT4sAVuPB4GtduM9ffm4GozlJqR1On9Latd61e2X4E3Czbu9e ZNAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=AG7BaGlvDzzIZG4ue2bsu8Ra9akm0M/YpULThgl+91Q=; b=hK78YS7DKxntT6eh+d8U5b8Rq/dVtuav/9F0BF3StbH4RlLL75e7vBM0ogFxY/pLH0 1ZL4PVS3gTYo8aUhmQMEIoyb03XIqojzhKELbKIqU3UqHixuJ45LIbOVKcsSn16sr+cf LcA/0/IUDhdionVii6SaVRDAk64JnkJtOD/9k0FrLea8LQqkBDytpS5g5RHD1a0ZotDI rWGzSviympstgsjSlm4kQRu2c+Ftoa3qHqKo+J4+j8+u/9c4kauszWDTF8MXz7JTYqTG wUwa2pNFKtXUaGr5DEy4v6VSO/DPQ1zwtoXSlT7gXwsGqYcokR6K+Ml7VXs1RJH+xCWq MncA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id oq2si4729712ejb.402.2019.11.14.19.16.32; Thu, 14 Nov 2019 19:17:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726549AbfKODQc (ORCPT + 99 others); Thu, 14 Nov 2019 22:16:32 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:49044 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726491AbfKODQc (ORCPT ); Thu, 14 Nov 2019 22:16:32 -0500 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xAF3GHPp000938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Nov 2019 22:16:18 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 900094202FD; Thu, 14 Nov 2019 22:16:17 -0500 (EST) Date: Thu, 14 Nov 2019 22:16:17 -0500 From: "Theodore Y. Ts'o" To: Chengguang Xu Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: code cleanup for get_next_id Message-ID: <20191115031617.GA30179@mit.edu> References: <20191006103028.31299-1-cgxu519@mykernel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191006103028.31299-1-cgxu519@mykernel.net> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun, Oct 06, 2019 at 06:30:28PM +0800, Chengguang Xu wrote: > Now the checks in ext4_get_next_id() and dquot_get_next_id() > are almost the same, so just call dquot_get_next_id() instead > of ext4_get_next_id(). > > Signed-off-by: Chengguang Xu Thanks, applied. - Ted