Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4543242ybc; Fri, 15 Nov 2019 06:23:50 -0800 (PST) X-Google-Smtp-Source: APXvYqzc+y0CvmHh+mdsw6G50xro9H9m66bqzkfRKpvoWwZQSiz3/7emNR4tA2aWvLf4TSPbLgns X-Received: by 2002:a17:906:4e99:: with SMTP id v25mr1312515eju.106.1573827830676; Fri, 15 Nov 2019 06:23:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573827830; cv=none; d=google.com; s=arc-20160816; b=TWICzeR1KCX5BrOhHvWz7/CFu9fIWC23ePrqzbiffFoRII95CERAwdQj0CsojRICpM ywXgGGhV84D2rQCUMtU5gUVcWqD9aG6+bQJ/6GlYxcHO3Q6xwAE6IQi5gaw8sqklZeg5 u0BsVvkpPh9XRkZ/YIksjQBrYvzA5mBh3IA5l25B6V8EW9uPRcPuvz26dgCIs6nuii3X 1I1l41WgCVjKoyiPOgWKotxQ1jj/83zi3MO3lYhw3j0If+mlSFtEacCOGEZeg7ScTWoQ A4S3xBQCFyo8BXnE0njLElSiHIv/zfQKrhF3DnVARBmsVlO6BTxVtTu23Jj0w3s1b7RM uSkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UtvpKXl6IWMPNNfew7dHDUvSx5eWY5YCs79iLp/L84c=; b=MS7QlIKQ39VTGLiTwp6NzPvRavdwFF43iLfajU4l6NpSFwSsF5yIWX8JwC8gRQlzax NDYesyxSDTwg83X7Mlss1MtjqyT8/OdOTYDccl6lIKvZEP5hCte1BnjQuIAtG8+GSG26 mWVDIUNZluYITsZ78StQySFaEL2LeJ+IKc42//gLRWI87OJ/sZt3HKg/GTEct1tYzuWu aVvEuEeNytvHNLQjn7m/Qsy4IdgTGB+CrZ4nauU4nJPtue4AF4AKI0D/XCk+9wekJgyB PltBPio9m85E4LbNaDImpqUNKnJh45dnbUvAmpIk+qjWBtK7hJz/s7bRXtaF+EYdtNCi 1suA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id uz25si5677833ejb.43.2019.11.15.06.23.24; Fri, 15 Nov 2019 06:23:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727406AbfKOOXT (ORCPT + 99 others); Fri, 15 Nov 2019 09:23:19 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:40065 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727380AbfKOOXT (ORCPT ); Fri, 15 Nov 2019 09:23:19 -0500 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xAFENDBm016898 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Nov 2019 09:23:14 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 21E9C4202FD; Fri, 15 Nov 2019 09:23:13 -0500 (EST) Date: Fri, 15 Nov 2019 09:23:13 -0500 From: "Theodore Y. Ts'o" To: Jan Kara Cc: linux-ext4@vger.kernel.org, Eric Biggers Subject: Re: [PATCH] jbd2: Make jbd2_handle_buffer_credits() handle reserved handles Message-ID: <20191115142313.GB23689@mit.edu> References: <20191115102210.29445-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191115102210.29445-1-jack@suse.cz> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Nov 15, 2019 at 11:22:10AM +0100, Jan Kara wrote: > The helper jbd2_handle_buffer_credits() doesn't correctly handle reserved > handles which can lead to crashes. Fix it getting of journal pointer to > work for reserved handles as well. > > Fixes: a9a8344ee171 ("ext4, jbd2: Provide accessor function for handle credits") > Reported-by: Eric Biggers > Signed-off-by: Jan Kara Thanks, applied. - Ted