Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp7835990ybc; Fri, 29 Nov 2019 01:49:35 -0800 (PST) X-Google-Smtp-Source: APXvYqw/VYvsRpDDXG4YgpXltp24V04zdtj0A5K2VVgHcJykhloy7171yRgEYjIWRLMe+73CkbCL X-Received: by 2002:a17:906:5351:: with SMTP id j17mr18976680ejo.66.1575020974849; Fri, 29 Nov 2019 01:49:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575020974; cv=none; d=google.com; s=arc-20160816; b=tB+taMO7q3xp6tbQBxqkIjDf4lvbZHc8AvITvyDTLc6q92KrU6n3jkREkb2lmALo4k TxsWaL4Gr4ic+f4ytg9oQuctvJlNsI5HtEcEnVt6VUGKtkFqU6eX+lS4W8jfPSjaxsTj lljRf9so+Lx9XJTdR5ExEU6LJElfv/Rdozr97sw1XbNy11YFXAW4+6/e4wljN7R4zrId B+zXrz+sxiJJBCBDrylm+8mcJrLh53gG3x79s7XoaoE4j9AluhA+UbzGHwARdgKHtZZ+ v5sJPaE0k87cBUanZFmymM1QZLDarhIo47DSAdPI0VRtYFY8havskoZ9C5uRQhU5HZrQ aQQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UojDHkAmZi8nNFVzqOGUKeInZICPfvAeWZxTHQFSj4U=; b=EfpKp5H1RcLkTVLRCeO2N5u5r1qeUfxm2LqJfaMqPtoVtimuEYXl3bqc+UaBFRPL2C bSCJR0VkP0A551qMMtuQLgorvqB1lpQWrOdy1YHtkysdUQNngIx0UORe16TR1mUmIohs dAJ84Y4fdzOKWYmW8MjMZegST/Bl/0fj36s4lFOvE+f4yw3Rt//GyEYPigOMc977RyUM FAsAZ0VbZ4HuTA+Fs7BuI412iFyjbO5UYEgrzgYDJS9Yuata7+bz6KWGIkbRMTgsVsge 8+tt2bpKJGloV2IKyToqRgn+w5uMVVskyD7y5xXasJrkI7pthmsf/RN6C75CJxRhlXd9 9xcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ce3si16830180edb.441.2019.11.29.01.49.00; Fri, 29 Nov 2019 01:49:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726143AbfK2Jsy (ORCPT + 99 others); Fri, 29 Nov 2019 04:48:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:53794 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725892AbfK2Jsy (ORCPT ); Fri, 29 Nov 2019 04:48:54 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 184FDAB7F; Fri, 29 Nov 2019 09:48:53 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id A56C51E0B63; Fri, 29 Nov 2019 10:48:52 +0100 (CET) Date: Fri, 29 Nov 2019 10:48:52 +0100 From: Jan Kara To: Chengguang Xu Cc: jack@suse.com, linux-ext4@vger.kernel.org Subject: Re: [Resend PATCH] ext2: set proper errno in error case of ext2_fill_super() Message-ID: <20191129094852.GA1121@quack2.suse.cz> References: <20191129013636.7624-1-cgxu519@mykernel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191129013636.7624-1-cgxu519@mykernel.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri 29-11-19 09:36:36, Chengguang Xu wrote: > Set proper errno in the case of failure of > initializing percpu variables. > > Signed-off-by: Chengguang Xu Thanks. I've added the patch to my tree. Honza > --- > Forgot to cc ext4 maillist, so resend it. > > fs/ext2/super.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > index 30c630d73f0f..74a9e3e71c13 100644 > --- a/fs/ext2/super.c > +++ b/fs/ext2/super.c > @@ -1147,6 +1147,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) > ext2_count_dirs(sb), GFP_KERNEL); > } > if (err) { > + ret = err; > ext2_msg(sb, KERN_ERR, "error: insufficient memory"); > goto failed_mount3; > } > -- > 2.20.1 > > > -- Jan Kara SUSE Labs, CR