Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp380695ybl; Wed, 4 Dec 2019 04:25:49 -0800 (PST) X-Google-Smtp-Source: APXvYqyf+biqXPbrJ74XWawKAgTSNdJ/ZOrqvz2It+wkK4oUZp/CFvxxlni2RMxn8lo0xwnQR1Jx X-Received: by 2002:a05:6830:2098:: with SMTP id y24mr2247673otq.312.1575462349185; Wed, 04 Dec 2019 04:25:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575462349; cv=none; d=google.com; s=arc-20160816; b=xAOKo30vDESeLvPpt6oX8KiP/qFhlOWK+YU4cuUOR53tXyBwHccISqHSS1FHTds2p5 Yr0y7rqbUna2alozgACzQVuk3n8HG/i6Y4/zg4VQKOfacA0e6yrEJFfLJCVYBDvkMl9S pJJww5cDc1jBFbxuENNzlQg30D3g2c1UQGhp+3vEXMLf7mChSFl7RJrL1f6AvMYQOoA4 lQY+QL9TwYh+BWp49gT3TbzLY96jLAC9tvbGYf0FKdqRtzmYz/s1dMmtK2ScmIeo3VbZ DAeIqj9F/HyXs1zMNd3NjMasLoMbyGxDRePtN7V3mB+i0N/+l6+eZNs+9WnCOBlgzazH CERw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=ZtvCCS0vMODK3FTjFB9h7Gb+yASuUmz2STiZRH7htcE=; b=bjuxso4Bxrx52IwTb8T43yU5zxDOEQN25r7tdnJxXOFVBaButvWxGtVIa+HxYnpoV8 NlTvofMgosdQPiGRmjmfpTkcjMGO+HCiGFli/AQE0oPEsAZo4IvNzSSSyG3qSr+LoJ3J To0dao3rcSWnH/FrBPCwODdYxLX8uvqCwSAVLUbFU8RiC4otO9Nv34lCVkHEM0Ob6Mst 8CeZmxdIZod4xqSs9wLtJykUx69YKonTjD1l9h3rqvaL+99PV1UkzBXdgqAQs0EIcz2i vqWdbuhaALCgX42iBNfrHfBGMwIg/UIXwZQbigFflUdOerxyAix+IqXxq84EsP5TX+oR yNIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b10si2808003otp.124.2019.12.04.04.25.36; Wed, 04 Dec 2019 04:25:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727798AbfLDMZ2 (ORCPT + 99 others); Wed, 4 Dec 2019 07:25:28 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:6750 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727554AbfLDMZ1 (ORCPT ); Wed, 4 Dec 2019 07:25:27 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 3CE9D4B517082CBB2919; Wed, 4 Dec 2019 20:25:26 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Wed, 4 Dec 2019 20:25:16 +0800 From: "zhangyi (F)" To: CC: , , , , , Subject: [PATCH v3 0/4] ext4, jbd2: improve aborting progress Date: Wed, 4 Dec 2019 20:46:10 +0800 Message-ID: <20191204124614.45424-1-yi.zhang@huawei.com> X-Mailer: git-send-email 2.17.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi, This series originally aim to fix ext4_handle_error() and ext4_abort() cannot panic because of we invoke __jbd2_journal_abort_hard() when we failed to submit commit record without setting JBD2_REC_ERR flag. I add patch 1 and patch 4 to switch to use jbd2_journal_abort() and do some cleanup job at this iteration as Jan suggested. I also add patch 3 to fix missing updating ESHUTDOWN problem in commit 818d276ceb8 "ext4: Add the journal checksum feature", please revirew this series and give some suggestions. Changes since v2: - Fix spelling mistakes in the first patch. - Keep JBD2_REC_ERR and remove the last place that invoke jbd2_journal_abort() with 0 errno and the corresponding logic in __journal_abort_soft(). - Fix missing updating errno in the jbd2 sb after jbd2 shutdown abort. Thanks, Yi. zhangyi (F) (4): jbd2: switch to use jbd2_journal_abort() when failed to submit the commit record ext4, jbd2: ensure panic when aborting with zero errno jbd2: make sure ESHUTDOWN to be recorded in the journal superblock jbd2: clean __jbd2_journal_abort_hard() and __journal_abort_soft() fs/jbd2/checkpoint.c | 2 +- fs/jbd2/commit.c | 4 +- fs/jbd2/journal.c | 111 ++++++++++++++++--------------------------- include/linux/jbd2.h | 1 - 4 files changed, 45 insertions(+), 73 deletions(-) -- 2.17.2