Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2569106ybl; Sat, 14 Dec 2019 14:54:00 -0800 (PST) X-Google-Smtp-Source: APXvYqwb/mte5Bvuvmr9I0MfKRUIuS9BxAtkar3ZzGlCYHF3uxoiG156S+dDDAhf0nMubs08MjF2 X-Received: by 2002:a9d:7495:: with SMTP id t21mr23228443otk.86.1576364039888; Sat, 14 Dec 2019 14:53:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576364039; cv=none; d=google.com; s=arc-20160816; b=Q79jOxpeHfdpcFaeIKXCt6B3MBAQlmUCBosrShwbPAPxTkrNezib6+fYsr5hmetgyN RwGD5gIquvjrDZSIbPeeIyv/HfN3LE23yVe/lH0Z3UyGU1F2qrChkFiMfJR/PatysGhh Ov95KWXRuPpS5sh+Mfd7Fpc1uJ3rhG+9Tat8tr4bk9SkLeK6SWoBK1JPwu2y/oWhFd+s TNwP2B9VxhWPtoIt9rlj2woM0GuyIEoy9HG4jijQG3WEdfCNAHUX/wmEfZiE7nXIpgKB CIn9mMGvIGy0IhV6nXZlzkk1j9gLJb6BVSNfJxgjDe2hCQlu3oWet+3W9FozOpa/mM74 hH9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=VJp0P7aAF357GH1RjpvzVOJ6CSFVZzHg5ZQExf0g96c=; b=M4obsTKU803UxRKotQpv3EtVwIPb09Pa0QzHdwsP8rb2rCd4CRStXD1HU/qkJyqk9P uyFiUF5I5VGmgYX/NVrLcFXj2e1GafdRd0crxntVdBOVHM2RPZe2/RMwBASiv3foEYaU 6hcnHBnj2GDl5OFylGWW5UOY0/lC/jyK/xiUPF7uszjNhqyvCk9QgVbeiHv27rgNPpBV actnQqzfJvk+AQYIjQu8wKUlliMYQ1UU21Y1s6/Y0D79AI5gsq0tfFgimfc2+GXvZagj UomtRzFKvV86kxjXpi1PLyryZbb4PUBVoqcXChfFwYzaWpwiToSbS3Rl/Vf20DJz0CFa H4Qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c12si7222421otp.310.2019.12.14.14.53.37; Sat, 14 Dec 2019 14:53:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726792AbfLNWxg (ORCPT + 99 others); Sat, 14 Dec 2019 17:53:36 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:42364 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726687AbfLNWxg (ORCPT ); Sat, 14 Dec 2019 17:53:36 -0500 Received: from callcc.thunk.org (ec2-3-216-189-230.compute-1.amazonaws.com [3.216.189.230]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xBEMrNf4027489 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 14 Dec 2019 17:53:25 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 27BAD4207DF; Sat, 14 Dec 2019 17:53:21 -0500 (EST) Date: Sat, 14 Dec 2019 17:53:21 -0500 From: "Theodore Y. Ts'o" To: Jan Kara Cc: yangerkun , linux-ext4@vger.kernel.org, yi.zhang@huawei.com, houtao1@huawei.com Subject: Re: [PATCH] ext4: reserve revoke credits in __ext4_new_inode Message-ID: <20191214225321.GB448096@mit.edu> References: <20191213014900.47228-1-yangerkun@huawei.com> <20191213093746.GA15331@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191213093746.GA15331@quack2.suse.cz> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Dec 13, 2019 at 10:37:46AM +0100, Jan Kara wrote: > On Fri 13-12-19 09:49:00, yangerkun wrote: > > It's possible that __ext4_new_inode will release the xattr block, so > > it will trigger a warning since there is revoke credits will be 0 if > > the handle == NULL. The below scripts can reproduce it easily. Thanks, applied. - Ted