Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp6139503ybl; Mon, 23 Dec 2019 00:21:28 -0800 (PST) X-Google-Smtp-Source: APXvYqwdRRH7P84XbhUhcYbC8M/oQ4R1TR4TJg2v+8TaLQ7XtzvnzfESlPqheEt/CZIEJTQONbU1 X-Received: by 2002:a05:6830:18e9:: with SMTP id d9mr22539141otf.332.1577089288076; Mon, 23 Dec 2019 00:21:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577089288; cv=none; d=google.com; s=arc-20160816; b=llLjXHslYMPRDHvwN6CTixfdNwWaUeRdDhxX8yILXTvJCBiPD9SZzafd2jwY5cw3DG ljMEhAYNe4gBa3/ncn09J91s2ujo7jKnP8dgTjHv0kpS1I5r00yso16uKpE5o6ezruAa O7QN4mE7aOTykbnCTVnYismbiDsTfP//7Uh3eSu6kQQQcGWeVmr34MrSVomj/Zz1V/Xj KyhlBsanAmOcF5an8umbKayEGTA5YN3e3n0+iCHP142Mp72vmigNYV2KoEdWDIlF+QT6 io7rDb3FzgAgaem3niqu4NrbU+/UjdO3btYuaFrI7Gv8ERKChZNeoixOB+C4jEgdqkey D8Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ztX4w5D1d4bGegGpN0EUfr6VTBjE/eoP7f8+ESVAA5Y=; b=s8F5zH9ksc07xaIeyDtZyYY5tizl3kbFOg/UMg0UVXETPyPSIcNRXdN3gH7dN8ofp+ Su7tKBGRGdhqhHnsc9d4yWHsd4oQXSiRrSYNYx5r8iKczzk6mRDP2Dki3PJ2xDJK1wc+ /IRgawB5MVAmr2APhnNnwwcCGfcYWXUqqQ1+LO/C6Q5bp750LSTb6rJOkRmUdNFNPImJ DPeDIuhphdZ7SqaRtwKfrxr8xQ2dTIUcYdThGMn5l4d9wSgrfHDemPWCyY3q8Q17YSM7 OV4JXCzobuBTuE7rRv2oWuCchlhZguFuexBjv6oXa6o5qavenZSpRHPE4VD5eQc5BnUe 0k3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JgMk4fE0; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w18si3842790otj.148.2019.12.23.00.21.18; Mon, 23 Dec 2019 00:21:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JgMk4fE0; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726137AbfLWIVC (ORCPT + 99 others); Mon, 23 Dec 2019 03:21:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:38654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725855AbfLWIVC (ORCPT ); Mon, 23 Dec 2019 03:21:02 -0500 Received: from localhost (36-236-5-169.dynamic-ip.hinet.net [36.236.5.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11FE320709; Mon, 23 Dec 2019 08:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577089261; bh=j9mpvD2vwVqJgqgRO1huDRjRF97+pmAiqRJqpb4yQWo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JgMk4fE0EfdHV0JXNpb2TasyUXF7PfAmCOc7uF/6HodTzMkS1oOJjyz//vZONpMPF CTxunEVo9DvwQ02weloIIbupCnBwGA2dP8GRrF3HJoITmTCK1dM8t6X+jj+e5Wq0Vp roYfVLl0NQiC3iKV9M78+5ehKLdjrHlMmLrzYxno= From: Andy Lutomirski To: Ted Ts'o Cc: LKML , Linux API , Kees Cook , "Jason A. Donenfeld" , "Ahmed S. Darwish" , Lennart Poettering , "Eric W. Biederman" , "Alexander E. Patrakov" , Michael Kerrisk , Willy Tarreau , Matthew Garrett , Ext4 Developers List , linux-man , Stephan Mueller , Andy Lutomirski Subject: [PATCH v3 1/8] random: Don't wake crng_init_wait when crng_init == 1 Date: Mon, 23 Dec 2019 00:20:44 -0800 Message-Id: <6fbc0bfcbfc1fa2c76fd574f5b6f552b11be7fde.1577088521.git.luto@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org crng_init_wait is only used to wayt for crng_init to be set to 2, so there's no point to waking it when crng_init is set to 1. Remove the unnecessary wake_up_interruptible() call. Signed-off-by: Andy Lutomirski --- drivers/char/random.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/char/random.c b/drivers/char/random.c index cda12933a17d..c6252a3a4aec 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -946,7 +946,6 @@ static int crng_fast_load(const char *cp, size_t len) if (crng_init_cnt >= CRNG_INIT_CNT_THRESH) { invalidate_batched_entropy(); crng_init = 1; - wake_up_interruptible(&crng_init_wait); pr_notice("random: fast init done\n"); } return 1; -- 2.23.0