Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp14884533ybl; Mon, 30 Dec 2019 19:49:19 -0800 (PST) X-Google-Smtp-Source: APXvYqxhOtC7gSXogUMHO87EB6t1oqAdq72x93aFZhmX0I8F/AFwXdNx+PwVke1hEG4uZShRuZNh X-Received: by 2002:a9d:6acd:: with SMTP id m13mr72945658otq.313.1577764159452; Mon, 30 Dec 2019 19:49:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577764159; cv=none; d=google.com; s=arc-20160816; b=rDRcF67SntMgGO2D6F91cAT/y8A+PjR+KBLP5+ix725XnjpISKQAxY9tGOU/kgsgHs 9aWlrmCAbaXuHT6XCslXc4vnoqncaSI4e+eXU/EDjHj/sFyQMeoH7FjIVYg5G4nFS9D2 BUmNx+sCbTHzmTbOru1rKMf7oxvC8/2DSwjgp5fTu8eB6CMG464iWQj7yvvkXyarBN9e kdVOTflbCDVF8eiNxS+guvXvmQXkzEGxBE2GuXssodIATwgzDiFHEMyQx/N9S8hGEXXO hroFHCn0WDFi3uJqWQ6OvVP4mHdcaT0BZHzosigYgnXP3B35pVgBFvRSA5Pk0tr+1jDW uGQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=GXGRgVHJLARvPsVYGguQbLcs2T332zXUHNl5kMraPwk=; b=a7eiCJNBSn0eLAbEN3w4mhHZxKsXYLKuNgnvtqMyLoHhRkmKp6thY0uOF65d4+eLsF 7wTKcSWfaY/mA7FT22guwefKVHdMbcQBQZ1tK2HB3QZNgP/s6khS8qaBQS7ekdIzsP8L frA8e5na5IeZe3wvFEaVcS9c5eoQcNOitLYRUDRQ3JUOvw9I40eagxUFOJ3lLzzjDf9q BOUbQyizjnpvG0VSQ2oT75j4EfL/GwWLVB7VL2xaV250MbaD0o8qvY2yNQmQGWpNTRYg EBR1Nr9UAZvKPEOFJCfVVcIseHI14gq0mx5WyYRtT6/PjUbkPZUex3w75TEtasp3erSg 4CNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w2si2456148oib.252.2019.12.30.19.49.08; Mon, 30 Dec 2019 19:49:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726816AbfLaDsG (ORCPT + 99 others); Mon, 30 Dec 2019 22:48:06 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:36651 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726605AbfLaDsG (ORCPT ); Mon, 30 Dec 2019 22:48:06 -0500 Received: from callcc.thunk.org (96-72-102-169-static.hfc.comcastbusiness.net [96.72.102.169] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xBV3m0WB007973 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Dec 2019 22:48:01 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id B9161420485; Mon, 30 Dec 2019 22:47:59 -0500 (EST) Date: Mon, 30 Dec 2019 22:47:59 -0500 From: "Theodore Y. Ts'o" To: Li Dongyang Cc: "linux-ext4@vger.kernel.org" , "adilger@dilger.ca" Subject: Re: [PATCH v3 2/5] mke2fs: fix setting bad blocks in the block bitmap Message-ID: <20191231034759.GF3669@mit.edu> References: <20191120043448.249988-1-dongyangli@ddn.com> <20191120043448.249988-2-dongyangli@ddn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191120043448.249988-2-dongyangli@ddn.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Nov 20, 2019 at 04:35:24AM +0000, Li Dongyang wrote: > We mark the bad blocks as used on fs->block_map > before allocating group tables. > Don't translate the block number to cluster number > when doing this, the fs->block_map is still a > block-granularity allocation map, it will be coverted > later by ext2fs_convert_subcluster_bitmap(). > > Signed-off-by: Li Dongyang Applied on the maint branch, thanks. (The other patches need to go on the e2fsprogs master/next branch, and the last is a kernel patch.) - Ted