Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp15561681ybl; Tue, 31 Dec 2019 10:10:40 -0800 (PST) X-Google-Smtp-Source: APXvYqw/ntIg9lEA85yc/QLTDH1EXcgZsG4FCXYdLCpSLAkESpNwqN1EJ5rp6i9NeQwzNF0JWf0s X-Received: by 2002:aa7:c59a:: with SMTP id g26mr77587520edq.109.1577815840724; Tue, 31 Dec 2019 10:10:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577815840; cv=none; d=google.com; s=arc-20160816; b=XgDZghonnZ47OtsIREEGRdwM3X117FI2ikoknJsiWWPmzdA0aUgLXksVXcGMeCBv/n /W/KvCPCk73mTgc266DjU97YMKUzEZZADA6uKWFW05GDOUEsXHJurzKRYenhXDK9ZtKF VrscGkByDqRmjO5No4gilXTRtRxlKV3e9GWD+PfV5KvW8d3fBF5/e3Tw+5KAEV46+dFq wF0jC2zWox9DUDTCT2iUNg20WXH+C1W2X/MYuZfBeXEizs7VyKI/6Ms/89vtj3K+pTVq 6+045mdfp53XxaDPPHPixnBDv/ryFxMGgU/OwKi9+xm7Sd0bCinUcfxmGklwlf/7bwz/ nogg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=gKWb1q/svI/xATKVkFTFjZ2R9V657YlUeLjaV+WwAQM=; b=o1xLTWfIMqrqqbijCZEVI723xS8sqDEU27zbx+Q6k5LKNRg/FmG8FLYiSJMw7fd3IC QyBZHsbtKH0k+g/NwG1ZPjU2tmYr/aTTBHxMIoVVdLqCUfUI/1lRsoi1o6TCeWoTDXux rAXocbjHgugz3CfFiWPtiLDSPHIWKO9iPET7OMncIWIFuljygdebrBXTJordMMaNWr24 aAyC7F9ccluNZkmCIkgt2YDbh1GrNtdVJJaXYSdIFHcONbV7E9TeAnjJ0wd4geWOOEvS vKGannhrabFOAo0jcIXqOo62PsOViAH01qLXeVuz+GZ7MqV86lWItyAUz4maAzpCq3Tq WITA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Tv2vc96n; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7si31081914eju.234.2019.12.31.10.10.09; Tue, 31 Dec 2019 10:10:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Tv2vc96n; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727111AbfLaSGD (ORCPT + 99 others); Tue, 31 Dec 2019 13:06:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:44426 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726720AbfLaSGC (ORCPT ); Tue, 31 Dec 2019 13:06:02 -0500 Received: from zzz.tds (h75-100-12-111.burkwi.broadband.dynamic.tds.net [75.100.12.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81999206D9 for ; Tue, 31 Dec 2019 18:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577815562; bh=70vBevy4J9nQlxPX3DTzGyimdtIp9FkcU7tji5hsTj4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Tv2vc96n4eFV75kyhilxPvc9cOmqdpC84WziCPqzwGyVTkiOO7YVfdzZgK4Aab7Dh HJurDhLEDThQTCx2+2pBqOfyfTZEbcQZSsPCrfD09jGwuaW1VZjf6ce2KZJ7rGS0QQ vkK7kKGlJ7i1SsIAqAXoGUW7GB1f2rQSULJ4we5s= From: Eric Biggers To: linux-ext4@vger.kernel.org Subject: [PATCH 5/8] ext4: fix documentation for ext4_ext_try_to_merge() Date: Tue, 31 Dec 2019 12:04:41 -0600 Message-Id: <20191231180444.46586-6-ebiggers@kernel.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191231180444.46586-1-ebiggers@kernel.org> References: <20191231180444.46586-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Eric Biggers Don't mention the nonexistent return value, and mention both types of merges that are attempted. Signed-off-by: Eric Biggers --- fs/ext4/extents.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 6c3f8c0ca83b..b2dee02ed238 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -1827,13 +1827,14 @@ static void ext4_ext_try_to_merge_up(handle_t *handle, } /* - * This function tries to merge the @ex extent to neighbours in the tree. - * return 1 if merge left else 0. + * This function tries to merge the @ex extent to neighbours in the tree, then + * tries to collapse the extent tree into the inode. */ static void ext4_ext_try_to_merge(handle_t *handle, struct inode *inode, struct ext4_ext_path *path, - struct ext4_extent *ex) { + struct ext4_extent *ex) +{ struct ext4_extent_header *eh; unsigned int depth; int merge_done = 0; -- 2.24.1