Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp21249691ybl; Mon, 6 Jan 2020 00:30:49 -0800 (PST) X-Google-Smtp-Source: APXvYqzhwJmT0COXpTkbYk1pnX9oj1q7EsodKSEEZhwaPP0VBW8yT/aPM3sRu5wwbEidBSjpwAcT X-Received: by 2002:a9d:8cb:: with SMTP id 69mr95236536otf.221.1578299446943; Mon, 06 Jan 2020 00:30:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578299446; cv=none; d=google.com; s=arc-20160816; b=Q7r8nIwIn/2p5A8jC3CZ5kYe7zQkRc8BpmhvNwbttehPc+IqlrUTsbM92fO7AgXO1p alVBCLse01ZmW4OdEvYYxfYIU7q4yHJa4H2nwRKZeONA/8+9KJe13VUZnSrOsEjwEB5R 8H2R9dXsuF1mh621sXefDA5seuf7JRGVw5XEUXEBc6ajYQs8/Saa5XByR2zDuBwAxf1+ RpVpcqmIQSFUVJEDy4SLaZK4qhzMRk+oxzdRUG8OQ9mNQPBZoNKZMx+z2pP2du6yKlRp q1fCfL/1gZvl+10XJtiodywzcuJHZ0GsYHJQtZZllhov9RWFiXpJEcdJonEWPkiXQMg4 hYXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:mime-version:user-agent:date:to:subject:from; bh=IH8bhm/iptwInTWx2eojZhZIMBd39uOyMQTIx21wFzY=; b=dCRi6QnBO7sv27HNL1IEHukjj3SDjnUFln7+Ja5Z9rrSZG0vPrmlFT0V/LRMQGqJeB rqHNIFxzyQf6sULH9YnEeXju57LKEg4ruzs7VXMMt1XI3nKqlsuX1VUTHFMgF/2NA5oG V5uIDLmlYeJX9023DclUpv50hcdhiQziE8MR1uJuX13MWGn5g7tZ2Jn0ICjyoSNWaaR9 tMq1Hc4fypZIxyXC29cGYIPPYfqlGNhUui4FuYBl7Hh+AVYS5xXP3NIjeQR8hkyvn9TH O9erKgpTcOc8zc/Za/L/EtCB5BUNa64MLcvEE0fLqUZx+UN4XFp0O4zii2AXiWtztqF0 i/Mg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2si34701232oth.267.2020.01.06.00.30.27; Mon, 06 Jan 2020 00:30:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725996AbgAFIa0 (ORCPT + 99 others); Mon, 6 Jan 2020 03:30:26 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:4020 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgAFIa0 (ORCPT ); Mon, 6 Jan 2020 03:30:26 -0500 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0068S7Nt101653 for ; Mon, 6 Jan 2020 03:30:24 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2xb92kt47w-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 06 Jan 2020 03:30:24 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 Jan 2020 08:30:22 -0000 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 6 Jan 2020 08:30:21 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0068UKgI34865568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 6 Jan 2020 08:30:20 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8AC71AE059 for ; Mon, 6 Jan 2020 08:30:20 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2EF41AE064 for ; Mon, 6 Jan 2020 08:30:20 +0000 (GMT) Received: from [9.199.159.50] (unknown [9.199.159.50]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP for ; Mon, 6 Jan 2020 08:30:20 +0000 (GMT) From: Ritesh Harjani Subject: About BUFFER_TRACE macro in include/linux/jbd2.h To: linux-ext4@vger.kernel.org Date: Mon, 6 Jan 2020 14:00:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 20010608-0012-0000-0000-0000037AD0C9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20010608-0013-0000-0000-000021B6E8FC Message-Id: <20200106083020.2EF41AE064@d06av26.portsmouth.uk.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2020-01-06_01:2020-01-06,2020-01-06 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=1 clxscore=1031 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001060078 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hello Community, A very happy new year to all of you!! :) Had some query on BUFFER_TRACE macro. Here it goes:- While debugging some issue w.r.t jbd2/bh I came across this empty macro definition of BUFFER_TRACE in include/linux/jbd2.h. Though this is called from multiple places, but I could not find any definition of this as such. I could see some patches on mailing list which are still calling this macro. So that means I am definitely missing something here. Could you please help me understand how can one use this "BUFFER_TRACE" macro for debugging? I could not find any ftrace event related to this macro. For my debugging as of now I ended up creating a file in include/trace/events/buffer_debug.h and added the definition of BUFFER_TRACE macro there. On more googling I did find some old patch which enabled CONFIG_BUFFER_DEBUG. http://people.redhat.com/sct/patches/ext3-2.4/for-2.4.19/98-debug/00-ext3-debug.patch But this seemed pretty old and I could not find anything latest on this which is related to above patch. Any pointers pls? -ritesh