Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp658432ybl; Tue, 7 Jan 2020 12:44:47 -0800 (PST) X-Google-Smtp-Source: APXvYqyGsEOjhNZDsLsUzBb9iqENqTbVwvAliFtqu2tKhizbtofWTQMe5d7GqYzEjpX0C2Cwi5Yl X-Received: by 2002:aca:4183:: with SMTP id o125mr223178oia.125.1578429887294; Tue, 07 Jan 2020 12:44:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578429887; cv=none; d=google.com; s=arc-20160816; b=0OHpVV4nLpoe5FJAcDEvXgAhzGPlHN5jppRLGhg2kV+CmUhRpvdZUTRFuEf6MsgznE //VIkfl+F8ClwaioThkO1pCRaZacORrb0Bjv4z+VF0Iu6euGZDT2hci8xtJ8ON4ERny9 U+kbsi46zFA3ol4mZj+C8c+0DCR+0HaGnKl/qaVWXQ+AmjtIrZPSZlbZDhVXGFqWWm/7 iuawCwrCoMSMrCemsV2CmWIKRjWxJUMd4su6jRwIuESAN5/lRxdXiOqUQ1gu4gpPwuOc xQ2mH2CwSZE4o0gS4JkvquiUfxmo+fkTZxh5S2/vq36n0urb0cUEK3XHfCEENq0Kubpg e0ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=FhBx95by75l0XDBz+vCnk9g0rY9SaYVa3KKTqxy+oCU=; b=aOw+POLUOmyyr7qOtmFghK5NY8qTcD9/K8iLNxNR0hysiqaiSSPWwZxUiGq5YAy6VT WRntFqymChT+Xx+7HNs+VvZ9FpA5Y1Vpbj4ztabDAdO6nXj2fHKbAfBpivnaA4N0rVdo XeSYsIQGHN08F07/lNUy31igz8/kHK8u1tAd33Kq8vpJ51GarceFoIBa6IZUWYpwxLfQ QKK/MXIFYWc+5x5RP4LVzq4pAmpcqmPYpYPmmh9o+b783XR6UHOUozdae5lQ2bcIrWys zUbD8QhNByh1H2+dXRkGnAZtoQ8CZhYNxjhlojnirNO0ARufLTB+Ja7h8eqBqLHASdia xpPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p18si673006otg.61.2020.01.07.12.44.30; Tue, 07 Jan 2020 12:44:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726820AbgAGUoB (ORCPT + 99 others); Tue, 7 Jan 2020 15:44:01 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:60931 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726142AbgAGUoA (ORCPT ); Tue, 7 Jan 2020 15:44:00 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-111.corp.google.com [104.133.0.111] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 007KgodT017056 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 7 Jan 2020 15:42:51 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 530E94207DF; Tue, 7 Jan 2020 15:42:50 -0500 (EST) Date: Tue, 7 Jan 2020 15:42:50 -0500 From: "Theodore Y. Ts'o" To: Andy Lutomirski Cc: LKML , Linux API , Kees Cook , "Jason A. Donenfeld" , "Ahmed S. Darwish" , Lennart Poettering , "Eric W. Biederman" , "Alexander E. Patrakov" , Michael Kerrisk , Willy Tarreau , Matthew Garrett , Ext4 Developers List , linux-man , Stephan Mueller Subject: Re: [PATCH v3 1/8] random: Don't wake crng_init_wait when crng_init == 1 Message-ID: <20200107204250.GF3619@mit.edu> References: <6fbc0bfcbfc1fa2c76fd574f5b6f552b11be7fde.1577088521.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6fbc0bfcbfc1fa2c76fd574f5b6f552b11be7fde.1577088521.git.luto@kernel.org> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Dec 23, 2019 at 12:20:44AM -0800, Andy Lutomirski wrote: > crng_init_wait is only used to wayt for crng_init to be set to 2, so > there's no point to waking it when crng_init is set to 1. Remove the > unnecessary wake_up_interruptible() call. > > Signed-off-by: Andy Lutomirski Applied with a spelling fix ("wayt->wait"). - Ted