Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Andreas Dilger <adilger@dilger.ca>
Mime-Version: 1.0 (1.0)
Subject: Re: About BUFFER_TRACE macro in include/linux/jbd2.h
Date:   Tue, 7 Jan 2020 15:12:03 -0700
Message-Id: <5FFDC259-0697-4505-B7DB-3E633CD03666@dilger.ca>
References: <20200106083020.2EF41AE064@d06av26.portsmouth.uk.ibm.com>
Cc:     linux-ext4@vger.kernel.org
In-Reply-To: <20200106083020.2EF41AE064@d06av26.portsmouth.uk.ibm.com>
To:     Ritesh Harjani <riteshh@linux.ibm.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

Hi Ritesh,
There were somewhat patch versions posted by Andrew Morton (akpm)
that may have more functionality.

Note that the block layer no longer needs to be patched for this to be
used. Instead you can use dm-flakey to cause it to discard writes to the
block device.=20

Cheers, Andreas

> On Jan 6, 2020, at 01:30, Ritesh Harjani <riteshh@linux.ibm.com> wrote:
>=20
> =EF=BB=BFHello Community,
>=20
> A very happy new year to all of you!! :)
>=20
> Had some query on BUFFER_TRACE macro. Here it goes:-
>=20
> While debugging some issue w.r.t jbd2/bh I came across this empty macro
> definition of BUFFER_TRACE in include/linux/jbd2.h.
> Though this is called from multiple places, but I could not find any
> definition of this as such.
>=20
> I could see some patches on mailing list which are still calling this
> macro. So that means I am definitely missing something here.
>=20
> Could you please help me understand how can one use this "BUFFER_TRACE"
> macro for debugging? I could not find any ftrace event related
> to this macro.
>=20
> For my debugging as of now I ended up creating a file in
> include/trace/events/buffer_debug.h and added the definition
> of BUFFER_TRACE macro there.
>=20
> On more googling I did find some old patch which enabled CONFIG_BUFFER_DEB=
UG.
> http://people.redhat.com/sct/patches/ext3-2.4/for-2.4.19/98-debug/00-ext3-=
debug.patch
> But this seemed pretty old and I could not find anything latest on this
> which is related to above patch.
>=20
> Any pointers pls?
>=20
> -ritesh
>=20