Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp978860ybl; Wed, 8 Jan 2020 08:57:46 -0800 (PST) X-Google-Smtp-Source: APXvYqyXqR6B9xX/5p+UaE4J4NRgg/1e+vD50nfsp7nzFy4RYPAz5DM581cfIa6qarLismj85LDm X-Received: by 2002:aca:5303:: with SMTP id h3mr3602377oib.109.1578502666624; Wed, 08 Jan 2020 08:57:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578502666; cv=none; d=google.com; s=arc-20160816; b=UzO/I0VtBvERsA2zqbBzsk8yYLLpJtwNTiOFKRNtrSpGwkv8bkoi4JDit5VcoDiZGT n8i0Z1VxQ+wr/y19INPSgjJAbw+UJoQJa/HPRUn5ueJQU9Bcfs8Th9Kv6GbllFAEgMzf 2Ku66nrQpPC/q/x2gZjpwBGjSCMB0ZkXMrt5OcolcZQ/bz/1Nw+NAtgVZYvjd98mNyhy aghQlTHL8ZT0F3Gnv37bZWNi5kBT8M9HMgp+wlXb/X045JJmsbxuHHSw6RE4I9zNbw4A fDHljWfST+j9HhigpMablGY8qEm/CKCzFBKaL2cWb/u0n2icXVnrvw+MA3DPWXJBS2mA m8mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=2/grOTBgUAvethVaNAqsX059fFfNkvhqoW88UGGxm7k=; b=DCVo0S9NFsHgjBOsP6fV6FJLr+pms5DgszEYZbHBL5dD+0iwIWI1zXRLVSZabyb23B N2tu9oTSGYqz8aPMxoM8RK7abt2Pr3UNB0JWwSGU0M1bl5iG2mcsdSg0M+p+JmIidHpe JzV231mZzG1mjlAx3OAXL1Twnl11ztc8EpSxNelv1zvp+D4YtfuMuoHGYMsCJYo4hw5s CjIaomrp5OIGdQ8SNneAYxW8Y18a7s9RhtVQ/RxBiuFCn9KLtVkT6Pfh8HfQlkU6kBi8 f3+IMPHJV9sKsFtedWWwowcjKTYH8hXE7KTfNg1zEwlsXnXQ1IW4sRXBl+CGo0MVTA4g twLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=EY7ctXSu; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si1983493otq.41.2020.01.08.08.57.30; Wed, 08 Jan 2020 08:57:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=EY7ctXSu; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729565AbgAHQ5Z (ORCPT + 99 others); Wed, 8 Jan 2020 11:57:25 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:59896 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727308AbgAHQ5Z (ORCPT ); Wed, 8 Jan 2020 11:57:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2/grOTBgUAvethVaNAqsX059fFfNkvhqoW88UGGxm7k=; b=EY7ctXSukj3r60Zq9V0xRGPZt pcoHDTBrU9/U/T9W/u7/lPBqYmJdHvn5joBgWqzJu1kAAB2agXa5CJ7F/4uJphAZaXGoYTLf6G5/P gcJvpUoZeccH3ZtoOX32cTJpBHYG4bWhyo6nyjiT6dZmk740K9aOUnm8QH7rSdOi2RFCL8bD+uHyw QMufaqnCW10JBHm5uCzrI3oylj/Q+JMQz+H5+Is4pS2PxVaj+FSGfRn1VBAKYsNfDu02oZlBsEDqJ sDCbs19FvbQfZpWPe5oSLlGfx2J6RXwCniDvD/bOgDRH5OzetrI29+4h1GU4MPNhYPQahNaivzf1l /o3ltpAug==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipEdq-000890-Pg; Wed, 08 Jan 2020 16:57:10 +0000 Date: Wed, 8 Jan 2020 08:57:10 -0800 From: Christoph Hellwig To: Andreas Gruenbacher Cc: "Darrick J. Wong" , Alexander Viro , Christoph Hellwig , Linus Torvalds , linux-kernel@vger.kernel.org, Jeff Layton , Sage Weil , Ilya Dryomov , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Chao Yu , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Richard Weinberger , Artem Bityutskiy , Adrian Hunter , ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, Jan Kara , YueHaibing , Arnd Bergmann , Chao Yu Subject: Re: [PATCH v4] fs: Fix page_mkwrite off-by-one errors Message-ID: <20200108165710.GA18523@infradead.org> References: <20200108131528.4279-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200108131528.4279-1-agruenba@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org I don't want to be the party pooper, but shouldn't this be a series with one patch to add the helper, and then once for each fs / piece of common code switched over? On Wed, Jan 08, 2020 at 02:15:28PM +0100, Andreas Gruenbacher wrote: > Hi Darrick, > > here's an updated version with the latest feedback incorporated. Hope > you find that useful. > > As far as the f2fs merge conflict goes, I've been told by Linus not to > resolve those kinds of conflicts but to point them out when sending the > merge request. So this shouldn't be a big deal. Also this isn't really the proper way to write a commit message. This text would go into the cover letter if it was a series..