Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 9 Jan 2020 11:22:54 +0100
From:   Jan Kara <jack@suse.cz>
To:     zhengbin <zhengbin13@huawei.com>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH] ext4: use true,false for bool variable
Message-ID: <20200109102254.GE27035@quack2.suse.cz>
References: <1577241959-138695-1-git-send-email-zhengbin13@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1577241959-138695-1-git-send-email-zhengbin13@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Wed 25-12-19 10:45:59, zhengbin wrote:
> Fixes coccicheck warning:
> 
> fs/ext4/extents.c:5271:6-12: WARNING: Assignment of 0/1 to bool variable
> fs/ext4/extents.c:5287:4-10: WARNING: Assignment of 0/1 to bool variable
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>

Looks good to me. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/ext4/extents.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 0e8708b..d8611be 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -5268,7 +5268,7 @@ ext4_ext_shift_path_extents(struct ext4_ext_path *path, ext4_lblk_t shift,
>  {
>  	int depth, err = 0;
>  	struct ext4_extent *ex_start, *ex_last;
> -	bool update = 0;
> +	bool update = false;
>  	depth = path->p_depth;
> 
>  	while (depth >= 0) {
> @@ -5284,7 +5284,7 @@ ext4_ext_shift_path_extents(struct ext4_ext_path *path, ext4_lblk_t shift,
>  				goto out;
> 
>  			if (ex_start == EXT_FIRST_EXTENT(path[depth].p_hdr))
> -				update = 1;
> +				update = true;
> 
>  			while (ex_start <= ex_last) {
>  				if (SHIFT == SHIFT_LEFT) {
> --
> 2.7.4
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR