Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4290493ybl; Mon, 13 Jan 2020 11:05:54 -0800 (PST) X-Google-Smtp-Source: APXvYqyyeVyTwoKbpiQuXubf7g0N7N6D9+JyKEgWrgWC1Fdh5kWmou+RLiaC6i4ORAelUfL+GQ2t X-Received: by 2002:a05:6830:605:: with SMTP id w5mr14745795oti.79.1578942354287; Mon, 13 Jan 2020 11:05:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578942354; cv=none; d=google.com; s=arc-20160816; b=ulzwfe5ttsb7S0FKCv3hDMelROQX3M2SfidSNa2LpF/3SBQsv/yeI3odYJwgqJxfJo XD+bMhMJcQFvlSIcIYOh0w0H//YTWboQndirLTEFOTL53Y83mJgwd7uMsaovQlPhPhCb 9eytvssx7zqrLgcuvEd++8DeEauIsU6Qn7ZLrmqTPbK2ATZSMpNO7hRipa0k/1+vQe97 F6HHG5frSTXJf+gI1OvO28I341BkB92+vdtQDfwU1vFxKM8SlLjgIMutc+uZ4ty6nCbI hEYZPc610HmVyyMQGpNCAenftyn95mfb+SQNB4oM1he9HnMVB3hBwJcSb6nv55PhZX49 FKZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=YM1x9JRMopDTdkZwFL9ygblFpL6yDA/mOD86WyP+ijU=; b=lu3xk5UOqWmx9Vj/SeOLG1uXijTy6M+KvGQE/1+5X5/TPhv83KocU/j91OY8/eqWPV JBvGz/wBIgjc7vsv6KwxlYVoqOPR6+AyAVknJEd6/0pfS3pXyD81REi9Jk5aasc9hD41 WZs7EKuFuw1q/Fg4cMITJJcccayoN2DAL5u/mSJ+K+Q2fR6MKwns61/qcE+hz0Jdoa9R z6palk30Y9y1fTU3bRp3W5NM7eOLFeoEu+uPyT4dLhFFZ1zQDSztCRxPPZ2BvKG1gBfn GESsxP+pZlyvo4UQPZcdVDQ5CHTUxApQ3lFtdwUyRXPgTsCcmGXXE2du+PQ2cIsKTLU4 cLCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s17si7271219otq.78.2020.01.13.11.05.35; Mon, 13 Jan 2020 11:05:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728759AbgAMTER (ORCPT + 99 others); Mon, 13 Jan 2020 14:04:17 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:50337 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726435AbgAMTER (ORCPT ); Mon, 13 Jan 2020 14:04:17 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-111.corp.google.com [104.133.0.111] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 00DJ40cB023674 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jan 2020 14:04:01 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id B6F314207DF; Mon, 13 Jan 2020 14:04:00 -0500 (EST) Date: Mon, 13 Jan 2020 14:04:00 -0500 From: "Theodore Y. Ts'o" To: Jan Kara Cc: zhengbin , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH] ext4: use true,false for bool variable Message-ID: <20200113190400.GE30418@mit.edu> References: <1577241959-138695-1-git-send-email-zhengbin13@huawei.com> <20200109102254.GE27035@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109102254.GE27035@quack2.suse.cz> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jan 09, 2020 at 11:22:54AM +0100, Jan Kara wrote: > On Wed 25-12-19 10:45:59, zhengbin wrote: > > Fixes coccicheck warning: > > > > fs/ext4/extents.c:5271:6-12: WARNING: Assignment of 0/1 to bool variable > > fs/ext4/extents.c:5287:4-10: WARNING: Assignment of 0/1 to bool variable > > > > Reported-by: Hulk Robot > > Signed-off-by: zhengbin > > Looks good to me. You can add: > > Reviewed-by: Jan Kara Applied, thanks. - Ted