Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5419218ybl; Tue, 14 Jan 2020 08:37:40 -0800 (PST) X-Google-Smtp-Source: APXvYqz77TB5FkaANJT3XDI+ifkco6aUPBEXgt7+GRp+ODy6svnfv/G1y1u+pgeTVHPLMblh/+Qy X-Received: by 2002:aca:3d7:: with SMTP id 206mr17660876oid.98.1579019860566; Tue, 14 Jan 2020 08:37:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579019860; cv=none; d=google.com; s=arc-20160816; b=JVkoKiCVhdFjgcdmU5YXIcJTl8YXmJtwY9zlmS7PCP/soW3qKSBVHR5IMSBJZ6/Ssb kmyCZVEh0OsBZi1EfArVGTM0XLD00MnxD17FQvMTkQJOBINKksEFLQqYRtNUXVb0z5TW p04GLewvutq7WrTbJIWdshC0z2dOivqRUp/1K4iTMplR2NiOpLc07G/s4nFX1y5E4Oo0 1DFMGyp1SYzweuQ98J8oYgHMbDQEzcERyy3bu7GVjwkYhSg8Lj3HoBZAFZazFyJJtFpn kuhFAtVDHfu+l5E1v8c+2lQvGRtv/ryld0hE0M1FDgxy20/eb3ze1aBJE05nimlbZAtj stqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=bJVaCxrwr35SB36/aaUlnDWktHBHuj0zzwzpoSHUEtA=; b=Vnr1wPONLUXT0DEcuPiUdOrX+XKZoWGFWeTAY9R+oHMMb5TzgAnX3bww8dnEykWEhy FdUF2v7LrGL7c5r4RDu3a9pP8OgCbQP6DMDEIEi3xjEbbl9xUJ3jFzaKiJY03G4rUWJC 21n8OjfJDTRDOKD/pRhpVvxYvJyMnIjXz488KKpI9KTEfZm2q5us9Tt65T6beEfYN32y 2N1GeX2B/VIjEcLzwliVdwyPzj2T9OLgA/y++KeIAI8EjUY0k5REe4889nnIEm8Aocn3 LE+HkA4KCjOW52RIitOWMQ7z6hru8L8IOdNYhK7W88LKFKN8YRrtqkp6ZskUjjbDZjYu VuiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=tnFM93Uq; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d1si6735369otf.58.2020.01.14.08.37.30; Tue, 14 Jan 2020 08:37:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=tnFM93Uq; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726450AbgANQhD (ORCPT + 99 others); Tue, 14 Jan 2020 11:37:03 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:56522 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbgANQhC (ORCPT ); Tue, 14 Jan 2020 11:37:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bJVaCxrwr35SB36/aaUlnDWktHBHuj0zzwzpoSHUEtA=; b=tnFM93Uqm/bykCKgamD0hnO71 XP1CdKWoB/HK8TuWpqMrQ0x7QXiwnq7GRhtz7bqqa8ph2tOVP64c/qJ6FV+NNEhibNfzlJ33o0my8 VFd/lvz/GQXoMFth57L1AqL+pZVlnWS8Z3Ozg/aeGbg+dfe+s77cZ1CBC5BisFCpAWWkF/XtHTzFy ouDrykJY4LPC1t5d0q3LfuY3KYUom7mhZThvlRNIq1BNCTSiGZNca3erHg1roAp0Td5NKBAa8KXlG uXMpsG4rgoHZHlve0dkxHtZFQnYtt/4gOPp3SVqzW+WCR5IUkPImENsEHHkHssABcRNYUE1g/Dc/j XX3jgrXHQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1irPBe-00037l-Hn; Tue, 14 Jan 2020 16:37:02 +0000 Date: Tue, 14 Jan 2020 08:37:02 -0800 From: Christoph Hellwig To: Ritesh Harjani Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, jack@suse.cz Subject: Re: [RFC 1/2] iomap: direct-io: Move inode_dio_begin before filemap_write_and_wait_range Message-ID: <20200114163702.GA7127@infradead.org> References: <27607a16327fe9664f32d09abe565af0d1ae56c9.1578907891.git.riteshh@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27607a16327fe9664f32d09abe565af0d1ae56c9.1578907891.git.riteshh@linux.ibm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Please add at very least the fsdevel and xfs lists to iomap patches. Using i_dio_count for any kind of detection is bogus. If you want to pass flags to the writeback code please do so explicitly through struct writeback_control.