Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp6700490ybl; Wed, 15 Jan 2020 08:50:13 -0800 (PST) X-Google-Smtp-Source: APXvYqyZCmWz0FelaG/QXzJXTAe/bvt3aqzzNfqK0S6RbnXxq/DTszUhZqsIIvXccvwgZqtiWPjG X-Received: by 2002:aca:4309:: with SMTP id q9mr570023oia.158.1579107013026; Wed, 15 Jan 2020 08:50:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579107013; cv=none; d=google.com; s=arc-20160816; b=sW0lh5B9CmA8vmUOlHAW48jtKpvQ11iADEGyvqXgu4A3CaN7grbby4YyJNwWbtMFEE NdWcurr9lTGxt0n5+dQGNuym9uqJYOPpOH2icQDgDzvN6xcLAHyzW6OozmcF/xsjwMe3 RU6mYrwi17pZ/V0DOWL9Q4ttRLLijJTCd14xlcYKaGhS2nDxby/lp+UMqcLZphVcwNit XoTJxbilAuGlx5iwjRBt4YINuG5aqKyOdUwEZNcQBhryXQoTuCnuOnW8WKGsIclSqm9Q qnJ2gRvwOBCDa774VNvnFmAtgqmv5szsuLPgMp9edb72w8uk1uiHmLHUvtbjlk1mUsrw tORw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=6y8snNReVf+lCu2sNANgK1dYJ375mf6U3yM7kZQBbUY=; b=JzmDAVtmOUos37t3fK1pme072Ytyh490gs/Crf1Nn9xAWlhybow/y0Jd9z5vRuNbcz nqKFmW0Ry4hcUSj69qpJImq3JhTmo38yo5Lhima04FSuT+NsjCRgkgIrr8CFkx6JQ3/t SLnMH2NWXje2qwWsbw8gsVKrVneaSXw5u9GxmVhdg52ld4mhkVVWflrsz6yBm5XlpOJ/ 5AvN6Vde2LgXRqJci3xEN7VHRejLdA4PwOEzuR3P6l2LmrkdoNyahwTQuOvqqp6eGIbn OMTskZ2/LR9AzVE2XXHIJv+GpJqG6XbpdFqpZ7pR4ZPPweyNmPnFE96NhG76PjIAYyFk 5zmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v26si11371823otj.0.2020.01.15.08.49.57; Wed, 15 Jan 2020 08:50:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728939AbgAOQso (ORCPT + 99 others); Wed, 15 Jan 2020 11:48:44 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:53502 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728896AbgAOQsn (ORCPT ); Wed, 15 Jan 2020 11:48:43 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-111.corp.google.com [104.133.0.111] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 00FGmT0f023135 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Jan 2020 11:48:31 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 0B1E04207DF; Wed, 15 Jan 2020 11:48:29 -0500 (EST) Date: Wed, 15 Jan 2020 11:48:29 -0500 From: "Theodore Y. Ts'o" To: Ritesh Harjani Cc: Jan Kara , Xiaoguang Wang , Ext4 Developers List , joseph.qi@linux.alibaba.com, Liu Bo Subject: Re: Discussion: is it time to remove dioread_nolock? Message-ID: <20200115164829.GB165687@mit.edu> References: <20200109163802.GA33929@mit.edu> <20200114233054.890D7A4040@d06av23.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200114233054.890D7A4040@d06av23.portsmouth.uk.ibm.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jan 15, 2020 at 05:00:53AM +0530, Ritesh Harjani wrote: > > I too collected some performance numbers on my x86 box with > --direct=1, bs=4K/1M & ioengine=libaio, with default opt v/s dioread_nolock > opt on latest ext4 git tree. > > I found the delta to be within +/- 6% in all of the runs which includes, seq > read, mixed rw & mixed randrw. Thanks for taking the performance measurements! Are you able to release more detail of what the deltas were for those tests? And how stable were those results across repeated runs? Thanks, - Ted