Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 25 Jan 2020 02:31:09 -0500
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     Jan Kara <jack@suse.cz>
Cc:     Vasily Averin <vvs@virtuozzo.com>, linux-ext4@vger.kernel.org,
        Jan Kara <jack@suse.com>
Subject: Re: [PATCH 1/1] jbd2_seq_info_next should increase position index
Message-ID: <20200125073109.GH1108497@mit.edu>
References: <d13805e5-695e-8ac3-b678-26ca2313629f@virtuozzo.com>
 <20200123111543.GC5728@quack2.suse.cz>
 <43e6a168-63b6-4a82-7b3d-5dd676b9f9bb@virtuozzo.com>
 <20200123140243.GA7914@quack2.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200123140243.GA7914@quack2.suse.cz>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Thu, Jan 23, 2020 at 03:02:43PM +0100, Jan Kara wrote:
> On Thu 23-01-20 14:30:14, Vasily Averin wrote:
> > 
> > 
> > On 1/23/20 2:15 PM, Jan Kara wrote:
> > > On Thu 23-01-20 12:05:10, Vasily Averin wrote:
> > >> if seq_file .next fuction does not change position index,
> > >> read after some lseek can generate unexpected output.
> > >>
> > >> Script below generates endless output
> > >>  $ q=;while read -r r;do echo "$((++q)) $r";done </proc/fs/jbd2/DEV/info
> > > 
> > > I've just tried and this works for me just fine with openSUSE 15.1
> > > (4.12.14-based) kernel. Is it some recent regression?
> > 
> > I think it depends on 
> > commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface")
> > In OpenVz7 we got complain after backport of this patch.
> 
> I see. OK. So please add tag:
> 
> Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface")
> 
> likely also:
> 
> CC: stable@vger.kernel.org
> 
> and you can also add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks, applied with the suggested tags.

						- Ted