Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1421514ybl; Fri, 24 Jan 2020 23:59:55 -0800 (PST) X-Google-Smtp-Source: APXvYqzj3r7qVck4lNde7pBg9umMkkrIwwm4RLQle/FqzJCA2izSJ1jlqxxJwDuU/uus3HMT32dV X-Received: by 2002:a05:6830:1615:: with SMTP id g21mr5790793otr.49.1579939194947; Fri, 24 Jan 2020 23:59:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579939194; cv=none; d=google.com; s=arc-20160816; b=oFnxN5NmwHa8zdXNwkKba96WqWFb4csQcJF7LXwzzFcLUqbfFgBmGIMsNIHwJ1S/t7 J/bdA6DUBzFN5RQJjaEomDcXUxj7fbC29PifzYEPWARuJVl7rHbkwQ9spcAhpiUBd9XO AEc4Wbg2JvGJnZspjWY8J2mClNfiRhI6oPiPnuteAzZcgq31pi0YmK3lLE7dLNXujrkB aaILRoJkh0A133tDdEFn65ItkuGmGHW3qUNItL005Cfn2Kj5XiNaep6A6aSOUSmbZNZ+ wwBbWvbQ+SOnip40XCYxEbe6h4IoY5PCkV8Q/Zqb0prnBB3MnwfgVkQ1NZIHoXIr7OKq y6hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=6iP0M4ocxEj5cy1noxOimMjMyPCceKHr2t9GvII6pLE=; b=iAy3ejLqrceEjfFwmG3mNWXB5cmz+rPYfF9TegY3uoALsga0ZoDrVtPy1f4xfnX/dF ANfKWOOJihQ1pv6DoU2mCmKpwd42nweYWE1M3CwxNrsZyrKSI5wXsOr97Fx1ruDM4OcM JX10PgU2O+BxZm19GxNELeLvxNMdC8DZgMLOuhuKe35SNxeDC+9cxbEhqnITkT0gPrSg kWBdgZMM35F02FGd+v/jK9WAd/C7M6gZoVAVXP5RS7zrTNIyR3P1VGiYNldmj5sPHtR7 8kO2nKfGrKgtyhwzMjRfhY12HzKHHcPHYDEpk1n9Ka/stwknnXTYqTH1u6EdHOTwzfBs mCVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x19si2062544otk.89.2020.01.24.23.59.18; Fri, 24 Jan 2020 23:59:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726303AbgAYH7R (ORCPT + 99 others); Sat, 25 Jan 2020 02:59:17 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:58268 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726293AbgAYH7R (ORCPT ); Sat, 25 Jan 2020 02:59:17 -0500 Received: from callcc.thunk.org (rrcs-67-53-201-206.west.biz.rr.com [67.53.201.206]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 00P7wxvB031944 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 25 Jan 2020 02:59:01 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 3D63C42014A; Sat, 25 Jan 2020 02:58:58 -0500 (EST) Date: Sat, 25 Jan 2020 02:58:58 -0500 From: "Theodore Y. Ts'o" To: "zhangyi (F)" Cc: linux-ext4@vger.kernel.org, jack@suse.com, adilger.kernel@dilger.ca, liangyun2@huawei.com, luoshijie1@huawei.com Subject: Re: [PATCH v3 1/4] jbd2: switch to use jbd2_journal_abort() when failed to submit the commit record Message-ID: <20200125075858.GI1108497@mit.edu> References: <20191204124614.45424-1-yi.zhang@huawei.com> <20191204124614.45424-2-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191204124614.45424-2-yi.zhang@huawei.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Dec 04, 2019 at 08:46:11PM +0800, zhangyi (F) wrote: > We invoke jbd2_journal_abort() to abort the journal and record errno > in the jbd2 superblock when committing journal transaction besides the > failure on submitting the commit record. But there is no need for the > case and we can also invoke jbd2_journal_abort() instead of > __jbd2_journal_abort_hard(). > > Fixes: 818d276ceb83a ("ext4: Add the journal checksum feature") > Signed-off-by: zhangyi (F) > Reviewed-by: Jan Kara Applied, thanks. - Ted