Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3821417ybl; Mon, 3 Feb 2020 07:10:52 -0800 (PST) X-Google-Smtp-Source: APXvYqyS5bpjdyylgJyeUDiJz4m0eNsD+fVFz6UK5ef/ghcKsx3tn10BphjrkdE46xsQdlOFVeC6 X-Received: by 2002:a54:468b:: with SMTP id k11mr14297645oic.134.1580742652440; Mon, 03 Feb 2020 07:10:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580742652; cv=none; d=google.com; s=arc-20160816; b=JMwQqU1asBRukPO17lpE1ZFfOm0GbGHRDUNEqvDFOd6pybgwWCtvnLj92gmNTo1zM5 nGu/uEzz8K/COJZRu/3Vv9iEWGE1MjfFoSmU1jV2PrQHmkcaEAiRsgZI+qlWEfaS8z8k JyWbpn7IJO39CZLl44VvoHBD6RRddnY1B7iMRZVDp9KMDoEEdtKoeefnpaHnsTI+6eGd Ua+amoyUe5/DDTQ/NxM/xLoT89GS6awTy8GrQAcgzj5//r7aKVI7WJylUagwDZnPomb8 AQkymnHUIT62ydqgRoAALuv70dE+o1nJknFw9DO64X7Dk6sHpj7/Cs0HmtcIEmCvcRjG ZMDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=pjPnSIkAPA4akkd4qyUI48MhVFKUJtzjjMjVJtA/RpQ=; b=BrDtwaQNlAAp6yuUbafls/LSyEbqJT5b2LZpjZuxGn0CCQXAqQIBWS0sqp0pjlBfv9 QGhcWD2/JJbniVRHJMt/bVkJZMVxCHn6+lRxRTJcxL/aBt/7C/jNd3PevC+zciQsqLEG ueflEPGTIGl6dFS8wCEj4skqQEvc5UDbhARCe650Q1UmT/wusi55S6CNGXk44DVcU1BJ 4RvHL+3/mAlmFUscMRH7u6wqzYtwJG3YC5t7i1wzVapPGiDc1zLNIOW1kLRqj7kw8qO1 cwQfbMrIpYy4k852RNp6/wanYd4QhqHgVVzSyf8yTckdKlmmvxB9MP2nD9FGQAbXoq/m scVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 9si8161626oiz.237.2020.02.03.07.10.36; Mon, 03 Feb 2020 07:10:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727704AbgBCOGQ (ORCPT + 99 others); Mon, 3 Feb 2020 09:06:16 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:55174 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727577AbgBCOGP (ORCPT ); Mon, 3 Feb 2020 09:06:15 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 10EF7DDEEB4248775E91; Mon, 3 Feb 2020 22:06:12 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.439.0; Mon, 3 Feb 2020 22:06:01 +0800 From: "zhangyi (F)" To: , CC: , , , Subject: [PATCH 0/2] jbd2: fix an oops problem Date: Mon, 3 Feb 2020 22:04:56 +0800 Message-ID: <20200203140458.37397-1-yi.zhang@huawei.com> X-Mailer: git-send-email 2.17.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi, Ted and Jan We encountered a jbd2 oops problem on an aarch64 machine with 4K block size and 64K page size when doing stress tests. Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008 ... user pgtable: 64k pages, 42-bit VAs, pgdp = (____ptrval____) ... pc : jbd2_journal_put_journal_head+0x7c/0x284 lr : jbd2_journal_put_journal_head+0x3c/0x284 ... Call trace: jbd2_journal_put_journal_head+0x7c/0x284 __jbd2_journal_refile_buffer+0x164/0x188 jbd2_journal_commit_transaction+0x12a0/0x1a50 kjournald2+0xd0/0x260 kthread+0x134/0x138 ret_from_fork+0x10/0x1c Code: 51000400 b9000ac0 35000760 f9402274 (b9400a80) ---[ end trace 8fa99273d06aeb63 ]--- These patch set can fix this issue, the first patch is just a cleanup patch, and the second one describe the root cause and fix it, please review. Thanks, Yi. zhangyi (F) (2): jbd2: move the clearing of b_modified flag to the journal_unmap_buffer() jbd2: do not clear the BH_Mapped flag when forgetting a metadata buffer fs/jbd2/commit.c | 36 +++++++++++++----------------------- fs/jbd2/transaction.c | 25 ++++++++++++------------- include/linux/jbd2.h | 2 ++ 3 files changed, 27 insertions(+), 36 deletions(-) -- 2.17.2