Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp245516ybv; Wed, 19 Feb 2020 20:36:41 -0800 (PST) X-Google-Smtp-Source: APXvYqxwN/NQ1SybhTXKPSy0Lakc81tpXUK6FtmOvskkp5RAUurpyfH8lJIOyC7QYho2pQ30rein X-Received: by 2002:a9d:7a96:: with SMTP id l22mr22039514otn.217.1582173400965; Wed, 19 Feb 2020 20:36:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582173400; cv=none; d=google.com; s=arc-20160816; b=hRyk4byRIFVB3gDoQKcWMpafnkmylI8j/1RQMP12VW28MvhM2DSkIdjvhLgUJ7BlU/ Ll5UUgQ7bn8LMCYBeXv/qcPEjZLwvZqgKGmLTLUqpAPEvlqEY55PqryEK3N5RIWqnuAs NAzZuBDXhm5voe+6RwYpgUlIBi4X/E++ERpss+Yo3TAo7zxXlYMMAJ3u1H8Oq1muMA7g P2YngiWcqQzR8bgwnQdlV2m6aiwKbvoRIRG/F0laidq1//9SYgqEHqWq9pvu1Ff77+B/ ai9rkqDyn1xaPRQvC0aZGRvxAurIC8zBTtwiapR9/yM2avEJV3t2BX0isNqiqgX4bAkx MQtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Dzfs97rtbzQAbQkurXk/4/LizA236T3Pjda9DA15JuE=; b=NS7kklR9bewYQtYxabVLzfxzxw02JWM5h4u/p539AJtMWhOQvWm9AKHRSsZ1zvEaiC UOxRY+4YQY159H2kzFpDS2f3Bow0aPSY/RlgUvJRhj50NMNbQLO98RHmxaJT0jvGI0aA qu2oaZwzW+IUPkR666yX/doQJg+mW2DlifVeLXWt4a2S2Gc3Pjj4ls9G6jg9J5vqILPD ipSwxhU1yVtTyUghyfmVT2PSgDdDq7dltvpsIVCYMH8uJyIy/WnBYoqR3sSpRY61yTHt oM7J8r2UEvHr+l+wKIBM0ma/LtUvG8ACtVU4gv03K67/6XFOV7sIKLkuu/ZdBHr0LXzN k7MQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 22si9873760oin.34.2020.02.19.20.36.28; Wed, 19 Feb 2020 20:36:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728114AbgBTEea (ORCPT + 99 others); Wed, 19 Feb 2020 23:34:30 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:37402 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727476AbgBTEea (ORCPT ); Wed, 19 Feb 2020 23:34:30 -0500 Received: from callcc.thunk.org (guestnat-104-133-8-109.corp.google.com [104.133.8.109] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 01K4YMgv020808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Feb 2020 23:34:23 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 1685F4211EF; Wed, 19 Feb 2020 23:34:22 -0500 (EST) Date: Wed, 19 Feb 2020 23:34:22 -0500 From: "Theodore Y. Ts'o" To: "Jitindar SIngh, Suraj" Cc: "linux-ext4@vger.kernel.org" , "paulmck@kernel.org" Subject: Re: [PATCH RFC] ext4: fix potential race between online resizing and write operations Message-ID: <20200220043422.GB476845@mit.edu> References: <20200215233817.GA670792@mit.edu> <6ad43fbad38c8f986f35995ed61f9077abd3b0cc.camel@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ad43fbad38c8f986f35995ed61f9077abd3b0cc.camel@amazon.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Feb 19, 2020 at 03:09:07AM +0000, Jitindar SIngh, Suraj wrote: > > One comment below where I think you free the wrong object. Yes, I had sent a self-correction about that mistake earlier in this thread. > With that fixed up: > Tested-by: Suraj Jitindar Singh Thanks for testing the patch and confirming that it fixes the problem you found! - Ted