Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp270183ybv; Wed, 19 Feb 2020 21:14:07 -0800 (PST) X-Google-Smtp-Source: APXvYqxQE8RFozBrmJgNhTb3yPMezBfkvm/BBmvgslxr36FmGySxyzvlpi8pAXrSyKIP7ivYQQmI X-Received: by 2002:a05:6808:b13:: with SMTP id s19mr791162oij.119.1582175647089; Wed, 19 Feb 2020 21:14:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582175647; cv=none; d=google.com; s=arc-20160816; b=N+8wrrJZiBnqTto1CA/WHmuztYjgY/3Wr1DUvEypjD0Cb4T7aX9ParI9sWjfVcwGdx UrN9Su/AVNrufb3yiKamGpZJbEYbarkBtJXA4H84mpp/t0veh3+D9R7P3MHvaMVNC1id YSFkZUWiXGT+8HrzKpAvR+ZzD13Bs3g5py2OeZckghtHXYkwnyc8M8oMF9nuDj5jVYp4 Z2IHOCcmYynOTrbEFp2qtgEdV/JyR/7wz2Pz8tYKhlrxSitozqkYhUZboKWmRp+PJ1Cb bFgFSMr++RxpRYMne993iLwFOeTIozd3t3jfEdduZo5RweqlTZkuzYUe22xLiq5BsgOT NHUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=8cJMgSxfofd0eB8DDT55KhItzBq4rqYff5GnxJZJsrQ=; b=FoKzpKrNsBuAPxwdO0PhprJUzuSSI9zG7QpYwVpYC7QYqcnEK1VJPYcw8RLlgc+aHQ Sh5IaAaUoOhBunYK7y4di3SuB5zJs+y9K/SPUjXzOM1R3xMr3lQFqa2aGVDQ7wT/qqUY iBN9FxgsKWAPBHe+v6/kMJ/M5BKoxCBWvhbo1PccDiKUlcS72ehOpeWgChIYgyXydNFG ZqGV0NdNxaArngonUMvtzKlVVhGvTjle+U0KEzHOwo5kIpUH1etF1OX0tTd0sBuuzzeT D5e8LAd8R3uKqQq2+DzundpsVZ1y7iZ0GcFlyQlgtT7Lg6MGf/G+6ETHhCT+66dTSwvd /DHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y5si1103479oto.170.2020.02.19.21.13.54; Wed, 19 Feb 2020 21:14:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725957AbgBTFNO (ORCPT + 99 others); Thu, 20 Feb 2020 00:13:14 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:45708 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725947AbgBTFNO (ORCPT ); Thu, 20 Feb 2020 00:13:14 -0500 Received: from callcc.thunk.org (guestnat-104-133-8-109.corp.google.com [104.133.8.109] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 01K5D89J028725 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Feb 2020 00:13:09 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 22E2E4211EF; Thu, 20 Feb 2020 00:13:08 -0500 (EST) Date: Thu, 20 Feb 2020 00:13:08 -0500 From: "Theodore Y. Ts'o" To: Suraj Jitindar Singh Cc: linux-ext4@vger.kernel.org, sblbir@amazon.com, sjitindarsingh@gmail.com, stable@vger.kernel.org Subject: Re: [PATCH 2/3] ext4: fix potential race between s_group_info online resizing and access Message-ID: <20200220051308.GF476845@mit.edu> References: <20200219030851.2678-1-surajjs@amazon.com> <20200219030851.2678-3-surajjs@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219030851.2678-3-surajjs@amazon.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Feb 18, 2020 at 07:08:50PM -0800, Suraj Jitindar Singh wrote: > During an online resize an array of pointers to s_group_info gets replaced > so it can get enlarged. If there is a concurrent access to the array in > ext4_get_group_info() and this memory has been reused then this can lead to > an invalid memory access. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=206443 > Signed-off-by: Suraj Jitindar Singh > Cc: stable@vger.kernel.org Thanks, applied. - Ted