Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFCv2 0/4] ext4: bmap & fiemap conversion to use iomap
To:     Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
        tytso@mit.edu
Cc:     "Darrick J. Wong" <darrick.wong@oracle.com>,
        adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, cmaiolino@redhat.com
References: <cover.1580121790.git.riteshh@linux.ibm.com>
 <20200130160018.GC3445353@magnolia>
 <20200205124750.AE9DDA404D@d06av23.portsmouth.uk.ibm.com>
 <20200205155733.GH6874@magnolia>
 <20200206052619.D4BBCA405F@b06wcsmtp001.portsmouth.uk.ibm.com>
 <20200206102254.GK14001@quack2.suse.cz>
 <20200220170304.80C3E52051@d06av21.portsmouth.uk.ibm.com>
 <20200220170953.GA11221@infradead.org>
From:   Ritesh Harjani <riteshh@linux.ibm.com>
Date:   Fri, 21 Feb 2020 09:46:43 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20200220170953.GA11221@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Message-Id: <20200221041644.53A9852052@d06av21.portsmouth.uk.ibm.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


On 2/20/20 10:39 PM, Christoph Hellwig wrote:
> On Thu, Feb 20, 2020 at 10:33:03PM +0530, Ritesh Harjani wrote:
>> So I was making some changes along the above lines and I think we can take
>> below approach for filesystem which could determine the
>> _EXTENT_LAST relatively easily and for cases if it cannot
>> as Jan also mentioned we could keep the current behavior as is and let
>> iomap core decide the last disk extent.
> 
> Well, given that _EXTENT_LAST never worked properly on any file system
> since it was added this actually changes behavior and could break
> existing users.  I'd rather update the documentation to match reality
> rather than writing a lot of code for a feature no one obviously cared
> about for years.

Well I agree to this. Since either ways the _EXTENT_LAST has never 
worked properly or in the same manner across different filesystems.
In ext4 itself it works differently for extent v/s non-extent based FS.
So updating the documentation would be a right way to go from here.

Ted/Jan - do you agree here:-
Shall we move ahead with this patch series in converting ext4_fiemap to
use iomap APIs, without worrying about how _EXTENT_LAST is being set via
iomap core code?


-ritesh