Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ext4/021: make sure the fdatasync subprocess exits
To:     Eryu Guan <guaneryu@gmail.com>
CC:     <fstests@vger.kernel.org>, <linux-ext4@vger.kernel.org>
References: <20200214022001.15563-1-yi.zhang@huawei.com>
 <20200223123411.GA3840@desktop>
From:   "zhangyi (F)" <yi.zhang@huawei.com>
Message-ID: <2c2b8a1b-64a3-8fd7-948f-ea7a777e2cf0@huawei.com>
Date:   Mon, 24 Feb 2020 19:31:06 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.0
MIME-Version: 1.0
In-Reply-To: <20200223123411.GA3840@desktop>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

Hi,

On 2020/2/23 20:34, Eryu Guan wrote:
> On Fri, Feb 14, 2020 at 10:20:01AM +0800, zhangyi (F) wrote:
>> Now we just kill fdatasync_work process and wait nothing after the
>> test, so a busy unmount failure may appear if the fdatasync syscall
>> doesn't return in time.
>>
>>   umount: /tmp/scratch: target is busy.
>>   mount: /tmp/scratch: /dev/sdb already mounted on /tmp/scratch.
>>   !!! failed to remount /dev/sdb on /tmp/scratch
>>
>> This patch kill and wait the xfs_io fdatasync subprocess to make sure
>> _check_scratch_fs success.
> 
> Yeah, that's a problem.
> 
> I think you could add another "trap" in fdatasync_work, as what
> btrfs/036 does:
> 
> 	trap "wait; exit" SIGTERM
> 
> So xfs_io will be waited by fdatasync_work before exiting.
> 

Thanks for your suggestion, I will do that.

Thanks,
Yi.