Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4427730ybv; Tue, 25 Feb 2020 20:03:25 -0800 (PST) X-Google-Smtp-Source: APXvYqyxD5h2/CJQyh5oxolHbMQdojDQJA1+TzvixG6NcV1kl+l0AdNFP2edqaUF1xwIp7VzjF00 X-Received: by 2002:a9d:64ca:: with SMTP id n10mr1463886otl.325.1582689805181; Tue, 25 Feb 2020 20:03:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582689805; cv=none; d=google.com; s=arc-20160816; b=gD7cWnh5xzkRunOpXbjFgtbpumqrNJn5RxOadsFw/5VjfgmxyoA81vkojUZ/2erdOj PM+yc8I6rynQuVSIk6then7DgRq9AriQumNNy023/bFVVE6gb1itlPkLvuBCNshRRa+f NYo8u37RlwJeXr5tXuBoXvMl3G2SpfAngcj5nSz+ebsqMVTw97OXmysEBAStcQ9M2/iD 84SeZRaMEI1o26QvWfzbAFtG2MEuxl36wQetMmWvT+DJFYuXSpudEx4u4rY0OWWeptS/ Bj6Nzxm9fy7oM+6KrvkreJI44J9Cw4D1C/NtGOprJUK5q/0Ubj8i4NLOcm8T//6eva0D 41xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=YlFttKnInk/FqmbpREcB5GVeOx6Z7cYZmxDZpjk6rYs=; b=oW6bsgjGA/HcYO5rvwidbgE5DjgREHWgbDBITCijN/jJTPkjOL3BLKPHzzxl3FzzYA hvt4x6ykh5dxlHIuCSr9Zs7cIqtMAEwg7JjfdaZ6B20K86pXG+3Hv7KXMKBBjRkZ4x5A UcASAm3SO+5nOpkXh7NStntEsXda2Oa0hugQsy1oIRtOrqRjpKyIOJKk091kwOJ0PaeH +BoAsxcZfXK3di26DcvgMcdJYsyMukeG3tv2IPowSHG+FvNL+kh2a9i7pxZeYncmZgp3 JSMA1qTfKRM0CA7s9o12Zj+A2kqYw8t4e9/9txjCslZnR5f9nSDtPfqvSG+XxxkxDW55 XuvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7si468504otk.277.2020.02.25.20.03.04; Tue, 25 Feb 2020 20:03:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726416AbgBZEDA (ORCPT + 99 others); Tue, 25 Feb 2020 23:03:00 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:10693 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726024AbgBZEDA (ORCPT ); Tue, 25 Feb 2020 23:03:00 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id ACD44E05E179D99C0981; Wed, 26 Feb 2020 12:02:57 +0800 (CST) Received: from localhost.localdomain (10.90.53.225) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 12:02:50 +0800 From: yangerkun To: , CC: , Subject: [PATCH] ext4: using matching invalidatepage in ext4_writepage Date: Wed, 26 Feb 2020 12:10:02 +0800 Message-ID: <20200226041002.13914-1-yangerkun@huawei.com> X-Mailer: git-send-email 2.23.0.rc2.8.gff66981f45 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.90.53.225] X-CFilter-Loop: Reflected Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Run generic/388 with journal data mode sometimes may trigger the warning in ext4_invalidatepage. Actually, we should use the matching invalidatepage in ext4_writepage. Signed-off-by: yangerkun --- fs/ext4/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index fa0ff78dc033..78e805d42ada 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -1974,7 +1974,7 @@ static int ext4_writepage(struct page *page, bool keep_towrite = false; if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) { - ext4_invalidatepage(page, 0, PAGE_SIZE); + inode->i_mapping->a_ops->invalidatepage(page, 0, PAGE_SIZE); unlock_page(page); return -EIO; } -- 2.23.0.rc2.8.gff66981f45