Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: Filesystem corruption after unreachable storage
To:     "Theodore Y. Ts'o" <tytso@mit.edu>
Cc:     linux-ext4@vger.kernel.org
References: <c829a701-3e22-8931-e5ca-2508f87f4d78@dupond.be>
 <20200124203725.GH147870@mit.edu>
 <3a7bc899-31d9-51f2-1ea9-b3bef2a98913@dupond.be>
 <20200220155022.GA532518@mit.edu>
 <7376c09c-63e3-488f-fcf8-89c81832ef2d@dupond.be>
 <adc0517d-b46e-2879-f06c-34c3d7b7c5f6@dupond.be>
 <20200225172355.GA14617@mit.edu>
From:   Jean-Louis Dupond <jean-louis@dupond.be>
Message-ID: <d19e44af-585f-e4a2-5546-7a3345a0ee66@dupond.be>
Date:   Fri, 28 Feb 2020 12:06:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200225172355.GA14617@mit.edu>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On 25/02/2020 18:23, Theodore Y. Ts'o wrote:
> On Tue, Feb 25, 2020 at 02:19:09PM +0100, Jean-Louis Dupond wrote:
>> FYI,
>>
>> Just did same test with e2fsprogs 1.45.5 (from buster backports) and kernel
>> 5.4.13-1~bpo10+1.
>> And having exactly the same issue.
>> The VM needs a manual fsck after storage outage.
>>
>> Don't know if its useful to test with 5.5 or 5.6?
>> But it seems like the issue still exists.
> This is going to be a long shot, but if you could try testing with
> 5.6-rc3, or with this commit cherry-picked into a 5.4 or later kernel:
>
>     commit 8eedabfd66b68a4623beec0789eac54b8c9d0fb6
>     Author: wangyan <wangyan122@huawei.com>
>     Date:   Thu Feb 20 21:46:14 2020 +0800
>
>         jbd2: fix ocfs2 corrupt when clearing block group bits
>         
>         I found a NULL pointer dereference in ocfs2_block_group_clear_bits().
>         The running environment:
>                 kernel version: 4.19
>                 A cluster with two nodes, 5 luns mounted on two nodes, and do some
>                 file operations like dd/fallocate/truncate/rm on every lun with storage
>                 network disconnection.
>         
>         The fallocate operation on dm-23-45 caused an null pointer dereference.
>         ...
>
> ... it would be interesting to see if fixes things for you.  I can't
> guarantee that it will, but the trigger of the failure which wangyan
> found is very similar indeed.
>
> Thanks,
>
> 						- Ted
Unfortunately it was a too long shot :)

Tested with a 5.4 kernel with that patch included, and also with 5.6-rc3.
But both had the same issue.

- Filesystem goes read-only when the storage comes back
- Manual fsck needed on bootup to recover from it.

It would be great if we could make it not corrupt the filesystem on 
storage recovery.
I'm happy to test some patches if they are available :)

Thanks
Jean-Louis