Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp590434ybf; Sat, 29 Feb 2020 10:38:50 -0800 (PST) X-Google-Smtp-Source: APXvYqzpll5bhIDFVJc/hC/S3lwEfL+KscxRndRAq+1jU+n+W7TwY80nfSPp35IPHQmp2tQvT0Hc X-Received: by 2002:a9d:7f98:: with SMTP id t24mr7996781otp.338.1583001530334; Sat, 29 Feb 2020 10:38:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583001530; cv=none; d=google.com; s=arc-20160816; b=wS+gGHgLWh9aIrb2OGkt1YYYSSYdj3KqOJiwjf3PAcYqMJYm4IdqmgimnNK8zNzol/ +p94PpFXP+eLocx3HOweIam/O0NW8U+IxqSxWtsrWYRashtlmDE82rZWg5BtHsKqHCPO xOyUfHbx1Ij/OG+Uy51VB0S2cY0cXswlkEyhSplBTj9murbveMfQWKsceOlgboZOmNEy 4DPX8frszeDyOd6HUyIzH6IHuirsJc8hD9qk6RWVAbiR+sEcspnNGNtZg7jxus4bNfA8 OTQ9EuJ5RDsFUPG8r84k78AZDbFw3IQRwf/urh8oyJWFecSuKSTynr3DL9Zdi9UjQNc/ EKPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=OTy0yPtYDwrV3jNk9SU40fPqQC1y8C9HA9Vpfemi3q4=; b=VsPM69WyShZB3DZLgxB5rjl4TJcOgZX7++e71o/Zd95EyAwIpT9a+v2dowbfKE6j4C aWPNhEO/k+QD5rYkPOTpUz6+0YwVho0ZvCiw2ZE23Rm+dhwsBfYvlwExLgy7FSpUOa5p c1NDtL+BUEVRQ71Nr7DjGH+TzUjUHkGB1unslHHo6AkA4HeoutivUJfE/LqIVXPGdbfA UBUuSWFFC4uugjSxlsSyydVWKvuN182AVx+6YKoBlruMbFBgFSjaxjX9FJURZkipPzpS 3pHy4zeOsjJWdU95bEpoDZ//dd5QxeGC9TEu1Fyqwhzfqok6dJvS/e4cbjl1+uDqSuZU 6B+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t185si3514011oib.39.2020.02.29.10.38.31; Sat, 29 Feb 2020 10:38:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727247AbgB2SRY (ORCPT + 99 others); Sat, 29 Feb 2020 13:17:24 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:47844 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727177AbgB2SRY (ORCPT ); Sat, 29 Feb 2020 13:17:24 -0500 Received: from callcc.thunk.org (75-104-88-164.mobility.exede.net [75.104.88.164] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 01TIHCjh021980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 29 Feb 2020 13:17:19 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 8439D42045B; Sat, 29 Feb 2020 13:17:11 -0500 (EST) Date: Sat, 29 Feb 2020 13:17:11 -0500 From: "Theodore Y. Ts'o" To: Murphy Zhou Cc: linux-ext4@vger.kernel.org Subject: Re: ENOSPC inline_data fsck failure Message-ID: <20200229181711.GD7378@mit.edu> References: <20200228105234.n5wt5x2vi3ftxuyh@xzhoux.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200228105234.n5wt5x2vi3ftxuyh@xzhoux.usersys.redhat.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Feb 28, 2020 at 06:52:34PM +0800, Murphy Zhou wrote: > > With inline_data mkfs option, generic/083 can easily trigger > a fsck failure like this: > > The testcase is doing a simple testing: make a small(256M) fs, > run fsstress in it, make it out of space. Then fsck. > > Not sure about is this an issue of ext4 filesystem or e2fsck > needs more options. This is an ext4 bug. It's been on my radar screen to investigate one of these days, but I've just never gotten around to it. I'm guessing the bug is the error handling case when an inline directory is getting converted directory where its contents are stored in data blocks, and the block allocation fails due to the ENOSPC. - Ted