Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 29 Feb 2020 18:29:14 -0500
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     Andreas Dilger <adilger@whamcloud.com>
Cc:     linux-ext4@vger.kernel.org
Subject: Re: [PATCH 4/9] e2fsck: reduce memory usage for many directories
Message-ID: <20200229232914.GD38945@mit.edu>
References: <1581037786-62789-1-git-send-email-adilger@whamcloud.com>
 <1581037786-62789-4-git-send-email-adilger@whamcloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1581037786-62789-4-git-send-email-adilger@whamcloud.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 06, 2020 at 06:09:41PM -0700, Andreas Dilger wrote:
> Pack struct dx_dir_info and dx_dirblock_info properly in memory, to
> avoid holes, and fields are not larger than necessary.  This reduces
> the memory needed for each hashed dir, according to pahole(1) from:
> 
>     struct dx_dir_info {
>         /* size: 32, cachelines: 1, members: 6 */
>         /* sum members: 26, holes: 1, sum holes: 2 */
>         /* padding: 4 */
>     };
>     struct dx_dirblock_info {
>         /* size: 56, cachelines: 1, members: 9 */
>         /* sum members: 48, holes: 2, sum holes: 8 */
>         /* last cacheline: 56 bytes */
>     };
> 
> to 8 bytes less for each directory and directory block, and leaves
> space for future use if needed (e.g. larger numblocks):
> 
>     struct dx_dir_info {
>         /* size: 24, cachelines: 1, members: 6 */
>         /* sum members: 20, holes: 1, sum holes: 4 */
>         /* bit holes: 1, sum bit holes: 7 bits */
>     };
>     struct dx_dirblock_info {
>         /* size: 48, cachelines: 1, members: 9 */
>     };
> 
> Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
> Lustre-bug-id: https://jira.whamcloud.com/browse/LU-13197

Applied, thanks.

					- Ted