Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp2074286ybf; Mon, 2 Mar 2020 01:17:29 -0800 (PST) X-Google-Smtp-Source: APXvYqwlizPkMt+3M3SEKSGmjoMIAikLYuprIzEpSMvLr7Cqd1a9wGZ2VTEgYGInBAJi8ymHnR+t X-Received: by 2002:a9d:da5:: with SMTP id 34mr11337723ots.226.1583140649169; Mon, 02 Mar 2020 01:17:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583140649; cv=none; d=google.com; s=arc-20160816; b=hlbZdL7kdjRQ3WVEKXgseOFfgDqF+sMcNDPPfAyzpQpsM3aUzv9dplzV4jM0lBlfko pkaFyE2jbtv0XyHfAOrQCSNVS1nCNYudOP4V/h3k5m4JxVIzUd80mv9oaxtjnop376d3 2/CmuwR1oxf5xWVqgCxpaTDALVViHXAGGSQFKWg/fh4kZOFF+1tNIl7w9OV8rzcieJI2 hwPQUHr03wFVidIS6kl39enXQ04rXDsbfLoIYt35VRbAVfQspsAcemxbC4HemG6chDPS iCg1Q0nWGDKxINvt6sDknDBP+pwIFylwmOkEZIttr3ahNfEYoDDamAaeAFxyZccmQG1W 6szw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=L9JdLvepX63VFdhhtIgkCgwHujtN1f/48K9z16179xs=; b=J68LdJEQXGZXiFuDNAzyhAWWcqGQNX0ouCFHyKf9A5lwarUS4R1Cgp92Sm34t4XlZ0 BRr/Fy2Y3OVXZoOuh7DUi//sx/AE/cltMqQ2cbMRdswMMA47lUpuZLXXhJ2gpuFKRqbA Yb6fGarph4wzmCyosR6WqvxI5LwEwmNTte2mNa2WjOXK1xEFMtSmSoDf/E8BdTR4Cr/Q kUBXMBOhuVLkCaTG+3Cu7TdKkxHyEguz7ffNn2oBa3HGl0cW18x0OKQUIFmkdsQ6WBXY JMOxtKuPg/QfTtK1eQVO5FP3VtB5Yky3PcGTe0xXtqjb3QqChm9lTroYrmf9yibABCjl HCzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1si536791otp.148.2020.03.02.01.17.15; Mon, 02 Mar 2020 01:17:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726654AbgCBJRN (ORCPT + 99 others); Mon, 2 Mar 2020 04:17:13 -0500 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:58533 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbgCBJRN (ORCPT ); Mon, 2 Mar 2020 04:17:13 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07417;MF=xiaoguang.wang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0TrOpaEa_1583140629; Received: from 30.5.112.20(mailfrom:xiaoguang.wang@linux.alibaba.com fp:SMTPD_---0TrOpaEa_1583140629) by smtp.aliyun-inc.com(127.0.0.1); Mon, 02 Mar 2020 17:17:09 +0800 Subject: Re: [PATCH] ext4: start to support iopoll method To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, jack@suse.cz, joseph qi References: <20200207120758.2411-1-xiaoguang.wang@linux.alibaba.com> From: Xiaoguang Wang Message-ID: Date: Mon, 2 Mar 2020 17:17:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200207120758.2411-1-xiaoguang.wang@linux.alibaba.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org hi, Ted, could you please consider applying this patch? Iouring polling tests in ext4 needs this patch, Jan Kara has nicely reviewed this patch, thanks. Regards, Xiaoguang Wang > Since commit "b1b4705d54ab ext4: introduce direct I/O read using > iomap infrastructure", we can easily make ext4 support iopoll > method, just use iomap_dio_iopoll(). > > Signed-off-by: Xiaoguang Wang > --- > fs/ext4/file.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ext4/file.c b/fs/ext4/file.c > index 5f225881176b..0d624250a62b 100644 > --- a/fs/ext4/file.c > +++ b/fs/ext4/file.c > @@ -872,6 +872,7 @@ const struct file_operations ext4_file_operations = { > .llseek = ext4_llseek, > .read_iter = ext4_file_read_iter, > .write_iter = ext4_file_write_iter, > + .iopoll = iomap_dio_iopoll, > .unlocked_ioctl = ext4_ioctl, > #ifdef CONFIG_COMPAT > .compat_ioctl = ext4_compat_ioctl, >