Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 5 Mar 2020 15:40:34 -0500
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Cc:     linux-ext4@vger.kernel.org, jack@suse.cz,
        joseph qi <joseph.qi@linux.alibaba.com>
Subject: Re: [PATCH] ext4: start to support iopoll method
Message-ID: <20200305204034.GC20967@mit.edu>
References: <20200207120758.2411-1-xiaoguang.wang@linux.alibaba.com>
 <c535d8f5-e746-30dc-f3e8-aeed04fcb5b8@linux.alibaba.com>
 <20200302191604.GD6826@mit.edu>
 <22af3309-cccf-57a8-af35-32c9e5fa06ca@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <22af3309-cccf-57a8-af35-32c9e5fa06ca@linux.alibaba.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 04, 2020 at 09:40:54PM +0800, Xiaoguang Wang wrote:
> hi,
> 
> Sorry for being late.
> > On Mon, Mar 02, 2020 at 05:17:09PM +0800, Xiaoguang Wang wrote:
> > > hi,
> > > 
> > > Ted, could you please consider applying this patch? Iouring polling
> > > tests in ext4 needs this patch, Jan Kara has nicely reviewed this patch, thanks.
> > 
> > Yeah, I had been waiting to make sure the fix: "io_uring: fix
> > poll_list race for SETUP_IOPOLL|SETUP_SQPOLL" was going to land.
> I confirmed that it had been merged into mainline.
> 
> > 
> > Am I correct that the bug fixed in the above fix isn't going to impact
> > xfstests (since it looks like there are no fio runs with the io_uring
> > engine at the moment)?
> Yes, I have run xfstests with "-g auto", with or without this patch, there always
> are six same failed test cases, so I think it won't impact current xfstests, thanks.

Thanks, applied.

						- Ted