Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp6284952ybf; Thu, 5 Mar 2020 17:16:23 -0800 (PST) X-Google-Smtp-Source: ADFU+vs2AgIJnXSEKj1bE6wTdHrU674IZzZ74UsivQHlSYQx+Uwa7LYWnleZanYW2rZcqXouFiA/ X-Received: by 2002:a9d:1d2:: with SMTP id e76mr529596ote.223.1583457383094; Thu, 05 Mar 2020 17:16:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583457383; cv=none; d=google.com; s=arc-20160816; b=I9sovxaUYfEgviDUfEpRxY8KmQjXVHzKiimDD8lEax+OANVgXCa3yZJQAJjlIDucp8 516Vjx5xew5TbVOHKEck97/hME5TFSd9fIJUv5nPC9dakfHjX245WqbjdvGQKlKTVLlf 3AoaYk1zP6zZyJf1zEbQUO9b2ya50nRKK8q9uvVhyPQIVln/xVdxea4WF3UFCZHX0RhD dllFA3z2HPrTn4tdnCE8BTdrqiKLTu7MOsFQoTGb/yBBv9KpyPhU07J2IdjqJSfgiFg1 quWPKpuZfVE/gjOsxii6R3FEBRYPWBXVSW64CmCgDqQmIr3umNu3i7frZyzZ4eVSL4TU Yjkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=vHfkXO97n1Hl8k005PdLgUF3PwSDbU1rcW+HrjuylJQ=; b=vQm+F96NiwlVINzKEcx07n5ECyJgCk2/7Jjvp8urjwMKcsMq/dKXUX43KbC0zMm4zg 28ALRGhOj8xdIvzZ8vonlk8dlme1XMJFLAYhmv2hw9rC5hD8cFh9KSHRmvanj3VFMH4r +s/iO3IxmEE0WL06nlweqvHqG0Z5GuOTuWENxzGOn0vuMbr5Qz4uYRUpkduO+Bdc3JPn eOnpdaY/ckhRvHVdXJ5JF3AgcIeftXFZABfvO4yFi/HCzfSTcpBzvUfiM9br/6kB0+zd zekcbkGoPgJg63wQUYkKqCZ1R73TLjfK5pYgfZUUFuENybRR2mJm2mbwZLndrVphI/A9 dQTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i8si382100otr.227.2020.03.05.17.16.11; Thu, 05 Mar 2020 17:16:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726259AbgCFBPD (ORCPT + 99 others); Thu, 5 Mar 2020 20:15:03 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:36288 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726173AbgCFBPD (ORCPT ); Thu, 5 Mar 2020 20:15:03 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-105.corp.google.com [104.133.0.105] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0261EgCi000943 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Mar 2020 20:14:43 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id D7BEF42045B; Thu, 5 Mar 2020 20:14:41 -0500 (EST) Date: Thu, 5 Mar 2020 20:14:41 -0500 From: "Theodore Y. Ts'o" To: "zhangyi (F)" Cc: linux-ext4@vger.kernel.org, jack@suse.cz Subject: Re: [PATCH] jbd2: improve comments about freeing data buffers whose page mapping is NULL Message-ID: <20200306011441.GJ20967@mit.edu> References: <20200217112706.20085-1-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200217112706.20085-1-yi.zhang@huawei.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Feb 17, 2020 at 07:27:06PM +0800, zhangyi (F) wrote: > Improve comments in jbd2_journal_commit_transaction() to describe why > we don't need to clear the buffer_mapped bit for freeing file mapping > buffers whose page mapping is NULL. > > Fixes: c96dceeabf76 ("jbd2: do not clear the BH_Mapped flag when forgetting a metadata buffer") > Signed-off-by: zhangyi (F) > Suggested-by: Jan Kara Thanks, applied. - Ted