Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp6421544ybf; Thu, 5 Mar 2020 20:33:53 -0800 (PST) X-Google-Smtp-Source: ADFU+vveE3xyvaMPIxlpYv080LsaliWfRmTW2zEmWa02n5Q+IIYVuKG9fN2ovXIcyFHeaXr2Mr3v X-Received: by 2002:a9d:6949:: with SMTP id p9mr613452oto.364.1583469233852; Thu, 05 Mar 2020 20:33:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583469233; cv=none; d=google.com; s=arc-20160816; b=AsriYKdJ3BHk2qjyCt91VITy3nlbLISl6qUPbRlKYDwRSR3spIY23/RB9zeG/gGdjk Ju2LWYVrRAwLwmRQK62QkUs9HL+uuCGJHNjKl5fzFVn9PW9GHoOvo3gfY512WhORyPsX vk0o1szFTAiZYqF+MNIqTg72Lhug4tg8HscH5IQtI7DLj5aHi2/g4O/6EWseypwbGhPQ hLpBEM58Gb3B1oz83itpDykG/QTezK1qqgvjTWhewYBkufFko/2W5V+Yxveju13YcC8+ UuTkLZGextNjUeSb9/EI2G2EfyRbrnzSb7PspdRbG4F4ShS6GrimscJls1D3fjZtg7fZ /9OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=um4UWtWhi/sWaCe1NaZuzut/oDtv9qOrJDjxcCLz8tA=; b=THKyuhVku9WIJvFicXdaCeCp/wt2Opq6xN8/DoY8pGcTfSZCHXe5VpqnExrS+JiXYQ HIlSkbI2EPxbcJx72QhRuVkhwD1Os5U81UtlknuybrfZGf65g0YDpDbPDgAESu8YAcaj f0rgOVRjAUQe9FzMvtrgNdVZYr/pA3uCVz4V77S5zuOwwNwn9ZvjKg9KSLxlmG0MKNeF wuJDVl8hW68t82CsYlM+r61vooYc8azW6fu2FIErpqFavfxHepVuFi9wp82Cfv/IWCwe M0n0evX57tdD41/7QnfLPXgeAoYP6MizYGsrQZtJM2ficXHSwbBuuwRtnWjr8L3U6zDC 6JNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d28si660874otf.3.2020.03.05.20.33.29; Thu, 05 Mar 2020 20:33:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726359AbgCFEd1 (ORCPT + 99 others); Thu, 5 Mar 2020 23:33:27 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:47714 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726317AbgCFEd1 (ORCPT ); Thu, 5 Mar 2020 23:33:27 -0500 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0264XK3O025045 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Mar 2020 23:33:20 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 1C7EC42045B; Thu, 5 Mar 2020 23:33:20 -0500 (EST) Date: Thu, 5 Mar 2020 23:33:20 -0500 From: "Theodore Y. Ts'o" To: Qian Cai Cc: adilger.kernel@dilger.ca, elver@google.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: fix a data race at inode->i_blocks Message-ID: <20200306043320.GM20967@mit.edu> References: <20200222043258.2279-1-cai@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200222043258.2279-1-cai@lca.pw> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Feb 21, 2020 at 11:32:58PM -0500, Qian Cai wrote: > inode->i_blocks could be accessed concurrently as noticed by KCSAN, > > BUG: KCSAN: data-race in ext4_do_update_inode [ext4] / inode_add_bytes > ... Thanks, applied. - Ted