Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <2BF8E155-34A0-4913-9B81-DC6CA1A4F6E0@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_91421AA8-ED0D-48E8-8379-8C41047C5BF9";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] ext4: mark block bitmap corrupted when found instead of
 BUGON
Date:   Tue, 10 Mar 2020 17:02:26 -0600
In-Reply-To: <20200310150156.641-1-dmonakhov@gmail.com>
Cc:     linux-ext4 <linux-ext4@vger.kernel.org>,
        Theodore Ts'o <tytso@mit.edu>
To:     Dmitry Monakhov <dmonakhov@gmail.com>
References: <20200310150156.641-1-dmonakhov@gmail.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


--Apple-Mail=_91421AA8-ED0D-48E8-8379-8C41047C5BF9
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Mar 10, 2020, at 9:01 AM, Dmitry Monakhov <dmonakhov@gmail.com> =
wrote:
>=20
> We already has similar code in ext4_mb_complex_scan_group(), but
> ext4_mb_simple_scan_group() still affected.
>=20
> Other reports: https://www.spinics.net/lists/linux-ext4/msg60231.html
>=20
> Signed-off-by: Dmitry Monakhov <dmonakhov@gmail.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> fs/ext4/mballoc.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>=20
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 1027e01..97cd1a2 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -1901,8 +1901,15 @@ void ext4_mb_simple_scan_group(struct =
ext4_allocation_context *ac,
> 		BUG_ON(buddy =3D=3D NULL);
>=20
> 		k =3D mb_find_next_zero_bit(buddy, max, 0);
> -		BUG_ON(k >=3D max);
> -
> +		if (k >=3D max) {
> +			ext4_grp_locked_error(ac->ac_sb, e4b->bd_group, =
0, 0,
> +				"%d free clusters of order %d. But found =
0",
> +				grp->bb_counters[i], i);
> +			ext4_mark_group_bitmap_corrupted(ac->ac_sb,
> +					 e4b->bd_group,
> +					=
EXT4_GROUP_INFO_BBITMAP_CORRUPT);
> +			break;
> +		}
> 		ac->ac_found++;
>=20
> 		ac->ac_b_ex.fe_len =3D 1 << i;
> --
> 2.7.4
>=20


Cheers, Andreas


--Apple-Mail=_91421AA8-ED0D-48E8-8379-8C41047C5BF9
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl5oHIQACgkQcqXauRfM
H+C8iRAAt3auppTYpj6wIHsJkAIpeThViFToNRBGK4P5+CVZqwVaHJbosgt4ycwL
p1ttTa4jpJXqQxYodmMGK4XVfQP9VIva98xAYLeuU3M33HdOKa57TzNz3WXiEAkn
xwNzCHehBqIpQxZe67UBretM5X88//TJNjF2iml+0M5j5XtvGgCjg7Sg1J/ChRPz
T19Sf2oEm82MW8lEWezAqWll+E3aPLbX+YchIffeEAFZOKAO2Q9MJqfz/0UoXD1b
lfuI2ZZP5mM3+DOi3eAEvJX/TZDF8NjC+pCOmfiiWjQt+d92Yn+jGVytXjJQSxEb
6TQbKlJhobT8gmTh3KVUzchh2vYCRwGO7P/0aEWd+Au4JRJlWICC0mes6AqAMX8y
W2csjccS6QIHjrENkcfdQ8HpW265kr1lnffNxgcssGI2w0ChHRBIxG6XyVSqpUqJ
rPusqMZa4sL6uKuqfQqCN2P86K9dgbmq7g2bmquCZh4AcCaul8g4/doWnlgrrCIP
aXMeGF1c562OaICSfvJZlJDGdoAyLj69Ptj6U3cXg7PydthlBt+wPHOxI8x/JNaP
zmw5gjmeDhTQnx4KyBzIjUeq83a4zNfIlui4nS4I6GBxAAk90Io/ZFiw89VW2yVi
ctUnzSL9JT4i8BBa8GCUGL+sWrGkzg/iZC/fzxdygCnSdh6GjzA=
=ojSm
-----END PGP SIGNATURE-----

--Apple-Mail=_91421AA8-ED0D-48E8-8379-8C41047C5BF9--