Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp378688ybh; Thu, 12 Mar 2020 03:50:39 -0700 (PDT) X-Google-Smtp-Source: ADFU+vty3teFqUJCTbPblaykduiSFN6bNKqBzRL7XtCvP3EXjC1zuO6ogJW1MEnDc08/x/YTmqwI X-Received: by 2002:a4a:bf19:: with SMTP id r25mr3437774oop.3.1584010239351; Thu, 12 Mar 2020 03:50:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584010239; cv=none; d=google.com; s=arc-20160816; b=lNXYDqsU7JKlKV/UwJkWbYmsAtjDNmLI+c36Pe6Tg52I+Rt2E542GsBW50ouFdS3Rz YNI5ya0TpSOysGzBWvUiXxkfmoarDGKuRHROq+6n2umHsbGtnj6QGQM9mEOMb+EdbVpy HApo3Lnlv0rphxjltsmx3HnMM4SGsI+KkzLRptLvkYrPRsq2fFQD0NOJzoA2DV+u+ATH JQP+AEPTQNNxyqcXbjdZ0p9vxzb2kIxM9D0DhWRLL8veA2YF0JCRjZn9PQRkGkydiAst wfhZrBikEqzvGeCrlVLj2E9zvMol5Ai5Iahs/I5niILa5U1DFFqftYBOnweDGoia8uvN IEgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :dkim-signature; bh=sqSyeraTyEfK9Qvci1PFdu1IIkWpjyFX2BvJmt2oSYM=; b=Aq8Sde2aJJQ7IJzwlb5M67/4lSvAY7FnbzMCphbmqOl+4BuAYaQZVHAvH7Fyko250g jilVrp6Dlmtvtpn6h3y99D6hIL6PRWrOut6nWlSwnHQfusZ6LJzhuOjCVOyeGsDmanUq 77eoew8aSmMoaxAOA6nfquJT1HcnwAGDN5DstJl7B3tpCkpwm4J/+2VFEUbky8gRquCG dQ1JY+ecgjrlO3AcEDvidCvjDk+RiYckTYJnC2VZmU8K9eYtF2g0sLz94tZ4+iZ3Y4Ai RBTzaQSxyS3jeppqixZmkxGNTBzHyAQo1jVlXX/dKq5Sxx+8wZCS5zoLyZPOsw47btj+ 1q4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JtQnI8bb; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o20si1430592oos.59.2020.03.12.03.50.27; Thu, 12 Mar 2020 03:50:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JtQnI8bb; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726725AbgCLKtu (ORCPT + 99 others); Thu, 12 Mar 2020 06:49:50 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27569 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727020AbgCLKtu (ORCPT ); Thu, 12 Mar 2020 06:49:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584010189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sqSyeraTyEfK9Qvci1PFdu1IIkWpjyFX2BvJmt2oSYM=; b=JtQnI8bbBFzLPkB09vo81J3Y/qaJ6IybKHv4spQJDbZvEGfT4HLWe750YH29q2Qu7CE47m aaSxd+UiGX++8szpFBWPsa3BQ3Fg2Wi7cZ55RbYSyIoFyF78fuvLAnccQy2k42ilakkaZv nr/WpqVDHxZrhLOFotT1LbI4kabjJfY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-300-FAJb1ijuOvKH_nCRC6Xbrw-1; Thu, 12 Mar 2020 06:49:45 -0400 X-MC-Unique: FAJb1ijuOvKH_nCRC6Xbrw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C1C17800D5E; Thu, 12 Mar 2020 10:49:43 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-182.rdu2.redhat.com [10.10.120.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0FE38AC4D; Thu, 12 Mar 2020 10:49:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20200312104239.GA13235@lst.de> References: <20200312104239.GA13235@lst.de> <969260.1584004779@warthog.procyon.org.uk> <1015227.1584007677@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, mbobrowski@mbobrowski.org, darrick.wong@oracle.com, jack@suse.cz, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: Is ext4_dio_read_iter() broken? - and xfs_file_dio_aio_read() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1023936.1584010180.1@warthog.procyon.org.uk> Date: Thu, 12 Mar 2020 10:49:40 +0000 Message-ID: <1023937.1584010180@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Christoph Hellwig wrote: > > > at the end of the function - but surely iocb should be expected to have > > > been freed when iocb->ki_complete() was called? > > The iocb is refcounted and only completed when the refcount hits zero, > and an extra reference is held until the submission has completed. > Take a look at iocb_put(). Ah... This is in struct aio_kiocb and not struct kiocb - that's why I missed it. Thanks. David