Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp614165ybh; Thu, 12 Mar 2020 08:00:56 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvmTN3xofjkjR5Oi2SnfAIEod1rA9TJUVLC8DAPcZwgjaZBVw2c+nDSH1MycIH6dC8IChLW X-Received: by 2002:a9d:7857:: with SMTP id c23mr630511otm.288.1584025255891; Thu, 12 Mar 2020 08:00:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584025255; cv=none; d=google.com; s=arc-20160816; b=k5qFyc4aoTT0nmR8wsNMJqs76Y9lUeBlsWXJ0E9SYmqgxEyDV7UC/cE6RxTszYWRii g78DONd4nYYgqhy4eSCWsuoOzwi7x9lgv/89MsXR91cCT3ijykBLIkq24dLMLds/GGzA azCja8UtH8YZieFyUAqR9R+/LomYtRsrb8A/q2A5cwRkfni/8PaGfrvM+6Hc7wRz1nit Hw63FY+p3307j3TZzXddCnpgyseZuj22jSjAhPgBjRfIaTLcw1zqijAXyTXmLWAAXMAM Mzk+8SqqJTLIedQtk3pQctHudgRAI2UrlzadPliLup+9KZ2itiqJEJMnSUP+dyqGd9yb tKmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=gtGyvcC4P9On7H7TGzRmkmgDeOrDqpACzvTBymBNG/Q=; b=LVLq7vRn2EkI0twSFS7mmoCRSgMsxm5rBNavk19qxFlTh6EhDQQlnYsHaPDWEP9IDj Q7jYbBd2behcXcyjPDp19mE6no0zcBt0zI78jk3SU8vjn0/Rwk3RkE2909MOSMPqL8zv 1ptL5r8wvhZC0gYG4tN2suoz9dxWO4icfAO/ATmHRqaTmVFh3/g84qGr9Df9jiMsWORv ou3YiE2/CXeMGCtax7kXr5kP0c/Mm/I/REZJn6RmwoAwlAeVkmR2dvFtuO7jLqrd5Av+ hLnAEKzJ+mvpBFbkWMwzTahLBj1sHTqKzDavFrD7sehuCe8MkfYf/O5m7vAk1KM4cTL/ 7dUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g22si1416330otn.104.2020.03.12.08.00.43; Thu, 12 Mar 2020 08:00:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727491AbgCLPA3 (ORCPT + 99 others); Thu, 12 Mar 2020 11:00:29 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:50941 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727489AbgCLPA3 (ORCPT ); Thu, 12 Mar 2020 11:00:29 -0400 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 02CF0Oll020674 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Mar 2020 11:00:25 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 4EED4420E5E; Thu, 12 Mar 2020 11:00:24 -0400 (EDT) Date: Thu, 12 Mar 2020 11:00:24 -0400 From: "Theodore Y. Ts'o" To: Eric Whitney Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: remove map_from_cluster from ext4_ext_map_blocks Message-ID: <20200312150024.GK7159@mit.edu> References: <20200311205125.25061-1-enwlinux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311205125.25061-1-enwlinux@gmail.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Mar 11, 2020 at 04:51:25PM -0400, Eric Whitney wrote: > We can use the variable allocated_clusters rather than map_from_clusters > to control reserved block/cluster accounting in ext4_ext_map_blocks. > This eliminates a variable and associated code and improves readability > a little. > > Signed-off-by: Eric Whitney Applied, thanks. - Ted