Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2115206ybh; Fri, 13 Mar 2020 13:06:24 -0700 (PDT) X-Google-Smtp-Source: ADFU+vulFZ5KzbE/0rNipNRgQebYMQpvC25uP6zrgyGY7wXm8mhB2sZ1A+2b/mR2RRGJ24weMmox X-Received: by 2002:a05:6808:a0a:: with SMTP id n10mr8596924oij.10.1584129984199; Fri, 13 Mar 2020 13:06:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584129984; cv=none; d=google.com; s=arc-20160816; b=bBLs7l1ZXOQ3ew9vr5PVoQ3jNYeVS4Y1K2XnxK76lpaZTNAcP4wWzCHKYm03DAyEcR titxAufLHNmd580VCseWxp0JGrm4+cbU5Lhmjz9Mg5R/Hn/CXSTrgyWSNmXyuQ/LfH+0 6jPSUI9nUSNa5GdFuGgjx7U13/4KFDWvaceFDemFh2D/wfD1yRoSwYlV1s4gKrVUjMbp tgWmIsZ/tC8yyJfo/HaHS3q/3Xah8lJISArodQexJShFhkJKtqqzCXEuee75r85Z3/Zk 6Wd2p35du38gdWFiY3hsGkvO90hqFOYHNBoB0cDrtiUzL1fb86ppDRASb02LDIR0UKbP zokg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=OUWtjn6rMJ08Cm0dtVjS10vsygfG/mx2ecoq2j+zfNA=; b=zgDH1Wt1ytImiy2YpBcQFH8J2jG6zeaUBhVHQeEZ61icxZNNzFIB+eVzVqZhNW2bB1 aYt8pPBgczoF5l6JeTizjnrFxwx5Jj+P4JCzNNvDh6rVlp7+jM6A4GtJoddWmPoZ7znW 12aL7ndsOKEA/V8VZV8/D3KO24PzqjABsEbL8m4OhpCqXvAhUk77fdjNtCmdn0bZu024 fqC1Vn4RG6i0op+TpNUD/iGrHSO7n2EUncc5Gc5s3lHqIlck+6Pj7PXhELknQifRtRno NnyMOey+slbn3WyUPiuf89Cnb6pso5d/EP5npnO1la49B3bXRGZEYN0hvu3PFj6zND+J P5IA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l15si5055314oic.220.2020.03.13.13.06.01; Fri, 13 Mar 2020 13:06:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbgCMUF6 (ORCPT + 99 others); Fri, 13 Mar 2020 16:05:58 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:60128 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726591AbgCMUF6 (ORCPT ); Fri, 13 Mar 2020 16:05:58 -0400 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 02DK5fWp031917 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Mar 2020 16:05:42 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id C1EA6420E5E; Fri, 13 Mar 2020 16:05:40 -0400 (EDT) Date: Fri, 13 Mar 2020 16:05:40 -0400 From: "Theodore Y. Ts'o" To: Ritesh Harjani Cc: linux-ext4@vger.kernel.org, jack@suse.cz, adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org, darrick.wong@oracle.com, hch@infradead.org, cmaiolino@redhat.com, david@fromorbit.com Subject: Re: [PATCHv5 2/6] ext4: Optimize ext4_ext_precache for 0 depth Message-ID: <20200313200540.GI225435@mit.edu> References: <93da0d0f073c73358e85bb9849d8a5378d1da539.1582880246.git.riteshh@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <93da0d0f073c73358e85bb9849d8a5378d1da539.1582880246.git.riteshh@linux.ibm.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Feb 28, 2020 at 02:56:55PM +0530, Ritesh Harjani wrote: > This patch avoids the memory alloc & free path when depth is 0, > since anyway there is no extra caching done in that case. > So on checking depth 0, simply return early. > > Signed-off-by: Ritesh Harjani > Reviewed-by: Jan Kara Applied, thanks. - Ted