Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 26 Mar 2020 10:57:11 -0400
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     Eric Sandeen <sandeen@sandeen.net>
Cc:     "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
        Ritesh Harjani <riteshh@linux.ibm.com>
Subject: Re: [PATCH] ext4: do not commit super on read-only bdev
Message-ID: <20200326145711.GS53396@mit.edu>
References: <4b6e774d-cc00-3469-7abb-108eb151071a@sandeen.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4b6e774d-cc00-3469-7abb-108eb151071a@sandeen.net>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 18, 2020 at 02:19:38PM -0500, Eric Sandeen wrote:
> From: Eric Sandeen <sandeen@redhat.com>
> 
> Under some circumstances we may encounter a filesystem error on a
> read-only block device, and if we try to save the error info to the
> superblock and commit it, we'll wind up with a noisy error and
> backtrace, i.e.:
> 
> [ 3337.146838] EXT4-fs error (device pmem1p2): ext4_get_journal_inode:4634: comm mount: inode #0: comm mount: iget: illegal inode #
> ------------[ cut here ]------------
> generic_make_request: Trying to write to read-only block-device pmem1p2 (partno 2)
> WARNING: CPU: 107 PID: 115347 at block/blk-core.c:788 generic_make_request_checks+0x6b4/0x7d0
> ...
> 
> To avoid this, commit the error info in the superblock only if the
> block device is writable.
> 
> Reported-by: Ritesh Harjani <riteshh@linux.ibm.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Thanks, applied.

					- Ted