Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1122277ybb; Sat, 28 Mar 2020 19:18:43 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsnbkIM8VG00gmhqv7plCvpaa5QkAn51TU6uM+RTB2v8NHPjptVmf/MgWAJp3FNZLWILNjl X-Received: by 2002:a05:6830:96:: with SMTP id a22mr4432858oto.212.1585448323610; Sat, 28 Mar 2020 19:18:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585448323; cv=none; d=google.com; s=arc-20160816; b=aMyf/htb0oBruUNl4ia9vaOx0hshe5cXTIfeBiYafVIdvsyMpEWtHrlgpyfFaQPicn 6KJL6UoKfUmXabxvbDwOnSet409Zuepd3pg/YGQ7xMzPSeWnsJP2PI3uoIzJ6ovJETVj DThBRNdyfEhWNmPFMHDPy+lC30Wi1nSddWNSX1tmomL5PPjSHcQ/1uLNo7y7wKaJ1GZY yZyZuDkSFhfEjCVfxyLIQp5mYSLSdigo91N6ze1gLeR7pnEP8f3ZvMpk0uikEV1odmD1 y6kRPq/R4QVOxtbARFGIa5tJSExtaHNSKBCC0Pl/mEYVX3j+hOVmZQfZD3/s22WX0zs2 0BmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=0thyvjd3gc3HC0ZrZ+/2bLVckiN7/clHAmuMtUmXysA=; b=cx7wBaa77w0bXn3yi7MKGY9RIs3yFeRvYBHA6eBp3T7FK9AL/HggSCZkS1giNDCPSH l1xKMLpyFmurHLSKIaZKBWJdwG2JJxXvJ5Q6Hy+fbS9Y1eGL+d5wsT+xBPy/AlR51VJl abNEyiirzAEQOuRDUBgugcaA9hTW78gdCUWfr59LgBu5vaLwUwNf1g9qJ6mHU/jLVA5f i0AlH8rERvTvcESn19xMH8fXdI4I+/ZgpVukhPjhFA+ju5P/rp3Ii8uwi3F2NmRY17b/ ehMdzuri1w8HzFLpQgxvKEWu7DpPAVK6lLVEYe4lEabz3JHR1XbepEVa6Zr9bJB+XIUz W4dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t2si4412481otb.284.2020.03.28.19.18.22; Sat, 28 Mar 2020 19:18:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbgC2CRf (ORCPT + 99 others); Sat, 28 Mar 2020 22:17:35 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:47340 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726463AbgC2CRf (ORCPT ); Sat, 28 Mar 2020 22:17:35 -0400 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 02T2HSRZ019673 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 28 Mar 2020 22:17:28 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 0B447420EBA; Sat, 28 Mar 2020 22:17:28 -0400 (EDT) Date: Sat, 28 Mar 2020 22:17:28 -0400 From: "Theodore Y. Ts'o" To: Ritesh Harjani Cc: linux-ext4@vger.kernel.org, Jan Kara , "Aneesh Kumar K . V" Subject: Re: [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize Message-ID: <20200329021728.GI53396@mit.edu> References: <87pndagw7s.fsf@linux.ibm.com> <20200327200744.12473-1-riteshh@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200327200744.12473-1-riteshh@linux.ibm.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Mar 28, 2020 at 01:37:44AM +0530, Ritesh Harjani wrote: > Currently on calling echo 3 > drop_caches on host machine, we see > FS corruption in the guest. This happens on Power machine where > blocksize < pagesize. > > So as a temporary workaound don't enable dioread_nolock by default > for blocksize < pagesize until we identify the root cause. > > Also emit a warning msg in case if this mount option is manually > enabled for blocksize < pagesize. > > Reported-by: Aneesh Kumar K.V > Signed-off-by: Ritesh Harjani Thanks, applied. - Ted