Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1127638ybb; Sat, 28 Mar 2020 19:30:23 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuQ+3BiNYVQFlXsAL9YXl2tQLsIzRHvEk1tZnsiF6HSVxlu8mgxVtoCNhCNz1FbM47RKWz/ X-Received: by 2002:a9d:6f07:: with SMTP id n7mr4345640otq.247.1585449023688; Sat, 28 Mar 2020 19:30:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585449023; cv=none; d=google.com; s=arc-20160816; b=OdpCZ0ag6freXZhgMSntTPtn494bMySPPHnzuevC//MUj+pHAT3b+oIwKOPquD4iCR baHHvZ+fiUkJj6QAlSwivcC1BKtIGbeTnB/M4jD8ondzHzlFaC6XFnJaOEAs5VF0Ewzg aW8T+tihF1T0q/GlWAspGewx7Zn7Vk1PTIU7hMhBoYVuTmIoGvKUU0X97LemA1gBGFsI qtDM0ZiNQBrW9bAzNCH0+Y7G51MrC3Tie5F2NJa0cs2/mfORjoHaSwt2F1u1prpoHtgE rQtqz+JA5hxzMk2xyANXlxX0WrBCk5V3GlFO4uQgQuTcdT3cI+diBl3t0xo4UP/WoZnZ zs+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=qcd0xbAgcrvcFfjU+fJRUQvCEmCNBzX5CZXqXp1MkWc=; b=YqH6xCfGnCsEqmc6w6O2vxI9q29QhecZfmtjk04Hxw+xpFRzpN5l3GWWKBVDLVo3k/ j8d00wZpFJF2YJ7P1kAD2Fm7QP+WT8CVGJEeOQHhA0L0ZcMe5Rfhc2+IT9UEC9dEDGB/ wWnVj+zvgcvIfIFxwUI98ZBOFe16s6T5KQHcwtcPq2IP62YL3CdyL/CR8dTrwAKLs+F3 ePji89NMvu80cyHFSPiVoFOhg6CqIMN5ahGZQT9f1gQJiS8nbEgISapLpk3BaxGTbqGm 36OjhjSUGfrdxnTfm5X8pERpQjgECChOB9Aonb5+QUO8Sz2xdH1TgNOoi0qdkT1nkKAO ExOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w24si4823449otq.131.2020.03.28.19.30.04; Sat, 28 Mar 2020 19:30:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726445AbgC2C3y (ORCPT + 99 others); Sat, 28 Mar 2020 22:29:54 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:48484 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726415AbgC2C3y (ORCPT ); Sat, 28 Mar 2020 22:29:54 -0400 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 02T2TjAB022243 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 28 Mar 2020 22:29:45 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 2740D420EBA; Sat, 28 Mar 2020 22:29:45 -0400 (EDT) Date: Sat, 28 Mar 2020 22:29:45 -0400 From: "Theodore Y. Ts'o" To: Josh Triplett Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Dilger Subject: Re: [PATCH] ext4: Fix incorrect inodes per group in error message Message-ID: <20200329022945.GJ53396@mit.edu> References: <8be03355983a08e5d4eed480944613454d7e2550.1585434649.git.josh@joshtriplett.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8be03355983a08e5d4eed480944613454d7e2550.1585434649.git.josh@joshtriplett.org> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Mar 28, 2020 at 03:34:15PM -0700, Josh Triplett wrote: > If ext4_fill_super detects an invalid number of inodes per group, the > resulting error message printed the number of blocks per group, rather > than the number of inodes per group. Fix it to print the correct value. > > Signed-off-by: Josh Triplett > Fixes: cd6bb35bf7f6d ("ext4: use more strict checks for inodes_per_block on mount") Applied, thanks. - Ted