Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2235303ybb; Mon, 30 Mar 2020 02:09:59 -0700 (PDT) X-Google-Smtp-Source: ADFU+vu4JTX94Mn7rXkHZdHPwOXn3TBA9SZQA4JHLTJkj4wD7lHf/krJYGgtcwOIzU7QhbTs5Unq X-Received: by 2002:a05:6830:1bef:: with SMTP id k15mr7992261otb.372.1585559399108; Mon, 30 Mar 2020 02:09:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585559399; cv=none; d=google.com; s=arc-20160816; b=npcTF2c449IrjP5ZCY2Kp2MEW2xw9tgQPozzFCVWiGepSdDgn4qbEMqlvk3FbOel5s blw9E49eBTsT1mZhFvpZRIpb6rse5/5JQxRzn27PrR2Lk9zV/TkfhlPy8uXvE1RVnqhY OyUOi5uHtDfFtPXTLkF02BAleyHtVhS+VVEOY7/YEdXgt/kjmrDTCAHGkBuASa+avKJg UcRRMfD2OEZkewQvk7A6856pWXRvAZChMOCPUwlkixaUU4N7fjXEWX7cEElgA/WfEuiX Eqj4CHXYIgbs43sP1htZMbR8DTNpfcNyPyTYrf4RDoJfxXhZ9GHwjLTc/skPSY0EO9Zw WH+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=vuspktFzY62W2dxdxj4C6hR0E0K1b3kcy7gCr9cK4NY=; b=mmdL0mywkFTcLT3zeCXYUhODqit3jbWFTF9eaW1AdJEcckvB3Jc7G8gvNPuUEb1+1i cgc6ilolYDIJTP/yxHWZio0oqbd0iOEqllo95Ar/45jxThgjRWl6PuOtu0X5tuy+KqJW wd3blDRhRaVDxN72S/JuJIE3WmZgxeJ/Tw2GYxSmCxaHARYUNDLkc3NdCF0j7K91tw0s eXqq4y1yeqUMSYcnWdm/W/LaBmHfIa1Oj8Y3cRakQCrRCwH+TkX67pa3ghhIaQjKIjFE CLiXoyrBgp6RdO6vgowWzSkDcA41wLr7pTt/VDLaWO6o5e/fDJoCoZFG3FrkhrpOkS7r 1RpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o20si5894132ota.17.2020.03.30.02.09.40; Mon, 30 Mar 2020 02:09:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729684AbgC3JJj (ORCPT + 99 others); Mon, 30 Mar 2020 05:09:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:39844 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729770AbgC3JJi (ORCPT ); Mon, 30 Mar 2020 05:09:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 98A70AFC0; Mon, 30 Mar 2020 09:09:36 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 021EE1E0E03; Mon, 30 Mar 2020 11:09:36 +0200 (CEST) From: Jan Kara To: Ted Tso Cc: , Jan Kara Subject: [PATCH 1/2] ext2fs: Fix error checking in dx_link() Date: Mon, 30 Mar 2020 11:09:31 +0200 Message-Id: <20200330090932.29445-2-jack@suse.cz> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20200330090932.29445-1-jack@suse.cz> References: <20200330090932.29445-1-jack@suse.cz> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org dx_lookup() uses errcode_t return values. As such anything non-zero is an error, not values less than zero. Fix the error checking to avoid crashes on corrupted filesystems. Signed-off-by: Jan Kara --- lib/ext2fs/link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ext2fs/link.c b/lib/ext2fs/link.c index 6f523aee718c..7b5bb022117c 100644 --- a/lib/ext2fs/link.c +++ b/lib/ext2fs/link.c @@ -571,7 +571,7 @@ static errcode_t dx_link(ext2_filsys fs, ext2_ino_t dir, dx_info.namelen = strlen(name); again: retval = dx_lookup(fs, dir, diri, &dx_info); - if (retval < 0) + if (retval) goto free_buf; retval = add_dirent_to_buf(fs, -- 2.16.4