Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Mar 2020 15:48:53 +0200
From:   Lukas Czerner <lczerner@redhat.com>
To:     Jan Kara <jack@suse.cz>
Cc:     Ted Tso <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext2fs: Fix error checking in dx_link()
Message-ID: <20200330134853.3icodnii6knomwch@work>
References: <20200330090932.29445-1-jack@suse.cz>
 <20200330090932.29445-2-jack@suse.cz>
 <20200330132440.4kwdwhgsrsnif6ju@work>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200330132440.4kwdwhgsrsnif6ju@work>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 30, 2020 at 03:24:40PM +0200, Lukas Czerner wrote:
> On Mon, Mar 30, 2020 at 11:09:31AM +0200, Jan Kara wrote:
> > dx_lookup() uses errcode_t return values. As such anything non-zero is
> > an error, not values less than zero. Fix the error checking to avoid
> > crashes on corrupted filesystems.
> 
> Looks good, thanks.
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>

of course that should be

Reviewed-by: Lukas Czerner <lczerner@redhat.com>

-Lukas


> 
> > 
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
> >  lib/ext2fs/link.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/ext2fs/link.c b/lib/ext2fs/link.c
> > index 6f523aee718c..7b5bb022117c 100644
> > --- a/lib/ext2fs/link.c
> > +++ b/lib/ext2fs/link.c
> > @@ -571,7 +571,7 @@ static errcode_t dx_link(ext2_filsys fs, ext2_ino_t dir,
> >  	dx_info.namelen = strlen(name);
> >  again:
> >  	retval = dx_lookup(fs, dir, diri, &dx_info);
> > -	if (retval < 0)
> > +	if (retval)
> >  		goto free_buf;
> >  
> >  	retval = add_dirent_to_buf(fs,
> > -- 
> > 2.16.4
> > 
>