Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <8304797A-1199-45A4-818F-1BBE598C73A6@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_3A269B50-DE8A-4B22-9741-67F33A88CFC7";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] libext2fs: avoid pointer arithmetic on `void *`
Date:   Sun, 5 Apr 2020 18:43:09 -0600
In-Reply-To: <20200405045346.21860-1-mforney@mforney.org>
Cc:     linux-ext4@vger.kernel.org
To:     Michael Forney <mforney@mforney.org>
References: <20200405045346.21860-1-mforney@mforney.org>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


--Apple-Mail=_3A269B50-DE8A-4B22-9741-67F33A88CFC7
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On Apr 4, 2020, at 10:53 PM, Michael Forney <mforney@mforney.org> wrote:
> 
> The pointer operand to the binary `+` operator must be to a complete
> object type.
> 
> Signed-off-by: Michael Forney <mforney@mforney.org>

Seems straight forward enough.  Not needed for GCC, but strictly correct.

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> lib/ext2fs/csum.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/ext2fs/csum.c b/lib/ext2fs/csum.c
> index 8513d1ab..c2550365 100644
> --- a/lib/ext2fs/csum.c
> +++ b/lib/ext2fs/csum.c
> @@ -274,7 +274,7 @@ static errcode_t __get_dirent_tail(ext2_filsys fs,
> 		rec_len = translate(d->rec_len);
> 	}
> 
> -	if ((void *)d > ((void *)dirent + fs->blocksize))
> +	if ((char *)d > ((char *)dirent + fs->blocksize))
> 			return EXT2_ET_DIR_CORRUPTED;
> 	if (d != top)
> 		return EXT2_ET_DIR_NO_SPACE_FOR_CSUM;
> --
> 2.26.0
> 


Cheers, Andreas


--Apple-Mail=_3A269B50-DE8A-4B22-9741-67F33A88CFC7
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl6Kex0ACgkQcqXauRfM
H+AlHA/+K/yIzip5shEh/ncbhTFUVsVp2MLl6YQ2JkT/bHEjhJkxGUFRnGE4m9c3
O4BleH5A4E+yWW83t4rWLyghpempGK8lB0bWVqB0fdYyE+GFRTpFWvHTVtsqlWmP
xrdLihoFbsHxdzcFMAhoYGVvgYMbj1GQOifg+R2CftNiqxDhiBTrr2FBKGiAVhED
VI1SKCgeCe4IW8r+NV780wCJ2GQLUetyr3kpcJwgRIkfq2Tk15xyvar8aK3hm6ox
8PFlMaaxMxAqT+5vlfoUE/d/LrbVbA59fNHR+/lJnuiCI3jM4I+tvs1/cv7a/aZx
CBnOSwi0wXtP5+8Xx4JMH9rZ6AuycXMfaFQSxLwr1pgFUJoEg0FDYTeTtptA/Spf
UOVmkXxVAF8AhmUJO9NgNchkbRkZvsQ+2ksN5NFsII6BEi9qEB+0Plo9U90QItSC
Jm76+yHY0ONwUYC0ctTsox/GyaQoA323Mj6vwUOLhFV9cw21LbNZYq5cRGYKb911
5/qgiNYP6aPvrmXC3E3VG2yQByrmnMkcreLeXTrjJu0zOCSfod/vK1TNvdBEqjYA
clsFX9f4hCL3f6BSJEPo5Sl7Kn2aOzm+Y//qVLTSAUGhykSf6Uz0Qgu6bvJ15Ruo
ZTewz2XxY3ZxsZhfIB8/CumJqeV1n6rJ47wSFW88K8q/h3zJzno=
=p8y1
-----END PGP SIGNATURE-----

--Apple-Mail=_3A269B50-DE8A-4B22-9741-67F33A88CFC7--