Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1607897ybb; Thu, 9 Apr 2020 05:42:11 -0700 (PDT) X-Google-Smtp-Source: APiQypJiUqgjcjXZZSZT7wm1Y1f3/g149JsSNiYFi9xTMyKfu3e90HH7AQA4Dn/UD9gA3o1+xM2O X-Received: by 2002:ad4:47cd:: with SMTP id p13mr12428125qvw.123.1586436131746; Thu, 09 Apr 2020 05:42:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586436131; cv=none; d=google.com; s=arc-20160816; b=gBnWYIJRSpXdWLB/Xk/hwezUbtbo+Rmm1K6a+WLeb7h42krY1SISyJ1DrCH/5TDX4r pjGEF9EJXgTB/mpMpVJ72SfYX3brW5VDpAUyqezv2kCWKfL6T6eGQcXaszrU6GnCoaFk V1Okc+omsUWbW58pa3Xsyyb9PSOq47O9cTcjoudLXzmPxhVYXeRXBI4JSYJpraW6dUIB iyixgQ89twRXMdNJyRJfwGgqWi2+FQo0raYbZb2U/3I6vt3/RbjAAvIMpD0dfculSFhQ R5EO82uMFVyEEW5k66KxuDqJjGD3guD8pjX8R62FEJ73MieP7TB/6xQJ3o5G2e89Gyr/ kpQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=wmp5guMg8hVP1x1l5Ppw+QSVjj1DcosVT+vzS4//JzA=; b=OPjYmehExcu3cltUz2HbflpiPNGz7v65AUVdarByt51h/ysYgzNdsExIEzpc/Qal6c ebrMXhDqt9+CfYSdmfdJ+VdP7YmVRQ0xKcLGMrKP2tDinyuMX4ZGkqaeDk5SNw2cHork c5GElxd0y56Hu/wBqvmUXR6F9G/8bZnHuV9yrDsLDtz9NHDFErIY/bZrLbpLNGT+Uh7w 2Ut9MZVhjjM8866tUJvDagmF2eP/tvKsSWjEJR94cV0p++U5HeygdXsMRS391j3iuxba 2LaEdEVx16EtO4u892PO7xqUtZYGDKBFB8ptcyCgmwhhSHKc43/v6wOfgEREu/8MH/d9 oH4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g14si5825306qvl.109.2020.04.09.05.41.56; Thu, 09 Apr 2020 05:42:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726621AbgDIMla (ORCPT + 99 others); Thu, 9 Apr 2020 08:41:30 -0400 Received: from verein.lst.de ([213.95.11.211]:46544 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726571AbgDIMla (ORCPT ); Thu, 9 Apr 2020 08:41:30 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 213DF68C4E; Thu, 9 Apr 2020 14:41:28 +0200 (CEST) Date: Thu, 9 Apr 2020 14:41:27 +0200 From: Christoph Hellwig To: Ira Weiny Cc: Dave Chinner , Jan Kara , Christoph Hellwig , Dan Williams , Linux Kernel Mailing List , "Darrick J. Wong" , "Theodore Y. Ts'o" , Jeff Moyer , linux-ext4 , linux-xfs , linux-fsdevel Subject: Re: [PATCH V6 6/8] fs/xfs: Combine xfs_diflags_to_linux() and xfs_diflags_to_iflags() Message-ID: <20200409124127.GB18171@lst.de> References: <20200407182958.568475-1-ira.weiny@intel.com> <20200407182958.568475-7-ira.weiny@intel.com> <20200408020827.GI24067@dread.disaster.area> <20200408170923.GC569068@iweiny-DESK2.sc.intel.com> <20200408210236.GK24067@dread.disaster.area> <20200408235836.GQ24067@dread.disaster.area> <20200409002203.GE664132@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409002203.GE664132@iweiny-DESK2.sc.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Apr 08, 2020 at 05:22:03PM -0700, Ira Weiny wrote: > > You mean something like XFS_IDONTCACHE? > > > > i.e. the functionality already exists in XFS to selectively evict an > > inode from cache when the last reference to it is dropped rather > > than let it go to the LRUs and hang around in memory. > > > > That flag can be set when changing the on disk DAX flag, and we can > > tweak how it works so new cache hits don't clear it (as happens > > now). Hence the only thing that can prevent eviction are active > > references. > > > > That means we'll still need to stop the application and drop_caches, > > because we need to close all the files and purge the dentries that > > hold references to the inode before it can be evicted. > > That sounds like a great idea... > > Jan? Christoph? Sounds ok. Note that we could also pretty trivially lift XFS_IDONTCACHE to the VFS if we need to apply the same scheme to ext4.