Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1729163ybb; Thu, 9 Apr 2020 07:59:49 -0700 (PDT) X-Google-Smtp-Source: APiQypKQ9nKhg09sy/RM4bwedyxJ72hwYYIIYdqFkKxONRDvqJeg1jfiOHviq7wMN27ifRQ2e11a X-Received: by 2002:a05:6214:132b:: with SMTP id c11mr433827qvv.150.1586444389721; Thu, 09 Apr 2020 07:59:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586444389; cv=none; d=google.com; s=arc-20160816; b=t2cx3UexEN2O++zhkOtpo2Rh05JjdQQGV+0pGuJTExyLyTa2F2Ldyb+JDfq0acB+5Q XBO2B+QEVFHG3dRR8Sf0a+Z+AMhheqn2ea/0/Ej6EVq3TGyEnlhm0/U42gfcu55SEPhC rBxEaZ8szhGrGQrnT4dhGG1Dvr+3d6pOc82Va2IO5c6lN8W9IiwQ4aD/YYF9aDYQ7s8G Zj55l2HptIufkkD0tE4U4DzLheLl4BrrMLkw9f7bcvwZd+VAOqys/beolrjJtB/NPBm7 Inj1JFu9cBbTo2ycIYU3GzCNmkLZuCiC0NihH6ViInKKk78hXhe/WoeR04GOfavUa+NX c+Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=9tv+abTlqfu24bQiTkAX8krBDncE7oQ3z/93ugukDGQ=; b=dXWGT7tn18kId5hklhJmiuMjXeHfrZgGwXb5ZrtJunvi/nC6VIRzpwvDUmWqHk7zeI jnhrH8aV9KLfGsFuqCz6xx6wY2AR2kxIVJ64wQhWWDHjHJ+sR8mE0dVFZOhPNufEAT5B Kg1YXDkRUe1hXjFfZ5a85uGprhQH+CrU3Qv1rm3jo79sBZeQYzrqLfaakZpnp0mASG8O yIjbDmJe4T7HK48UsV+EVs5EubJrWd3JfsrqXR+4YTztSXxLovs1hwTqyZO+XgFooQSn ZnjG1XNjX8MyMc6cXLCx1TyNIxGnx/kCGL/e8BWYDW6ddPTdmNqWVvEvUMp0hpuatlQY iv3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p67si6054918qke.51.2020.04.09.07.59.28; Thu, 09 Apr 2020 07:59:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727901AbgDIO5s (ORCPT + 99 others); Thu, 9 Apr 2020 10:57:48 -0400 Received: from mga12.intel.com ([192.55.52.136]:43830 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727815AbgDIO5s (ORCPT ); Thu, 9 Apr 2020 10:57:48 -0400 IronPort-SDR: +8O6pwnemwrKSqSh+fFrfOmtUnRm7BiVFT1l6Cu002rGQdAHf2DAZZRYZk9fVTycRmGctKdAcc Bi4w8lEXRDgg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 07:57:48 -0700 IronPort-SDR: hWIHqFJAKXewk6/sKwLmSZsN92xEpLx2GPDTgP2gywa6d7/KUy8wCmqL7INQxhknGssoSm/7+z 7dsmfMxNOd0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,363,1580803200"; d="scan'208";a="286912897" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by fmsmga002.fm.intel.com with ESMTP; 09 Apr 2020 07:57:48 -0700 Date: Thu, 9 Apr 2020 07:57:48 -0700 From: Ira Weiny To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, Dave Chinner , Jan Kara , "Darrick J. Wong" , Dan Williams , Dave Chinner , "Theodore Y. Ts'o" , Jeff Moyer , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH V6 2/8] fs: Remove unneeded IS_DAX() check Message-ID: <20200409145747.GF664132@iweiny-DESK2.sc.intel.com> References: <20200407182958.568475-1-ira.weiny@intel.com> <20200407182958.568475-3-ira.weiny@intel.com> <20200409073134.GA31376@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409073134.GA31376@lst.de> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Apr 09, 2020 at 09:31:34AM +0200, Christoph Hellwig wrote: > On Tue, Apr 07, 2020 at 11:29:52AM -0700, ira.weiny@intel.com wrote: > > static inline bool io_is_direct(struct file *filp) > > { > > - return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host); > > + return (filp->f_flags & O_DIRECT); > > } > > As requested last time: Can you please also just remove io_is_direct? FWIW I just found this mail in my junk folder... My fault I know... :-/ Regardless I did not see that request last time but I can do that, Done for V7 Ira