Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2036417ybb; Thu, 9 Apr 2020 13:52:19 -0700 (PDT) X-Google-Smtp-Source: APiQypJFgj89MYK2Mg2unoJPxqNtN/LmKtuvBQ610K9VLvlxCOJcgc3+JY/7hTs+W+1TF+MqtfEr X-Received: by 2002:a37:6213:: with SMTP id w19mr725499qkb.447.1586465539440; Thu, 09 Apr 2020 13:52:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586465539; cv=none; d=google.com; s=arc-20160816; b=oSqjpMEBqtHUjeoNjL+ysZ5AvTUfgHjsiIfqNp51i90w3DyJrm3n6BIozB6mhZvhX6 az863k74P8VVhyGNTVYR+O18y8dil+veIvFAXDUpbKB+gdIM31aqpArVeGVNTTjbYcCa lrrhUzngmhzggPJ6c7RUc8wJ8AiDghoPvPyrey0fJYgJ0vThnE94MKnRhm+ttI4xL1rh jbhzhxfGqWgUC5S6O8NAiUV7D2kTe3q2ICQrKgMIWwnLNqqCG/D1nPS25Gq+GyjelTve m7tGS6snpx4jtl+UU6rCCHvjE0Sawn5WUc2+ZRQ84IDfuQpkq/9BItbnwlVhqFWFecop 3vwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=wsewai9fLjoZCtQ1knDj+sRl7VgUVdHk6EdjPiHciBo=; b=szm6SEy2nGv/F2MYvtHcs8MwK3p2nbt2NDuNAt5qhih/MFP5ysxAzQWvr5cr6NpkU0 od1BLxAkzn77hS7Fx+vfIzlJdu3aMqBFMNKhZLiC2nfDA6s+P0ItlSgR3GnoPVyD1Sbx ZyLV4VjnwTgTtE4N2FSvAmJQsIE1RDVCDpPFJ9Lb9j9oJ7lpKzpcb6qXr4V13zHy0vwf 1kjfZ9mNtJph/HFE5O0gQLbuuUncHz2/euOWWsMTNRFZoOwm5bRxFlbSawGNVQPi5D0h yEqEGEKkCfZL5qOuxkm49zo1rhAbMdV9o08RiEkgZawcTIoCfqf1xfeq3AmI9ApktjtX pQFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f19si4547420qve.155.2020.04.09.13.51.49; Thu, 09 Apr 2020 13:52:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727077AbgDIUtz (ORCPT + 99 others); Thu, 9 Apr 2020 16:49:55 -0400 Received: from mga17.intel.com ([192.55.52.151]:43445 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbgDIUtz (ORCPT ); Thu, 9 Apr 2020 16:49:55 -0400 IronPort-SDR: uXuWMNIRaWcJ3HWZL8ZTsRL/q4urg2weWeN1PdqnxNbjT8SlR3aEoGHjDucOfUB8ItnLhqSjB5 C44WU4ixg5TA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 13:49:54 -0700 IronPort-SDR: uGT2DQfawKjjxTzrrboYSQ2lFlqOecSpTc00bpqC/04zZXNNxhOiDe9kG3EkErDx95QHN0t0w6 ULbqkaHAeq0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,364,1580803200"; d="scan'208";a="452138957" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by fmsmga005.fm.intel.com with ESMTP; 09 Apr 2020 13:49:53 -0700 Date: Thu, 9 Apr 2020 13:49:53 -0700 From: Ira Weiny To: Christoph Hellwig Cc: Dave Chinner , Jan Kara , Dan Williams , Linux Kernel Mailing List , "Darrick J. Wong" , "Theodore Y. Ts'o" , Jeff Moyer , linux-ext4 , linux-xfs , linux-fsdevel Subject: Re: [PATCH V6 6/8] fs/xfs: Combine xfs_diflags_to_linux() and xfs_diflags_to_iflags() Message-ID: <20200409204952.GB801897@iweiny-DESK2.sc.intel.com> References: <20200407182958.568475-1-ira.weiny@intel.com> <20200407182958.568475-7-ira.weiny@intel.com> <20200408020827.GI24067@dread.disaster.area> <20200408170923.GC569068@iweiny-DESK2.sc.intel.com> <20200408210236.GK24067@dread.disaster.area> <20200408235836.GQ24067@dread.disaster.area> <20200409002203.GE664132@iweiny-DESK2.sc.intel.com> <20200409124127.GB18171@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409124127.GB18171@lst.de> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Apr 09, 2020 at 02:41:27PM +0200, Christoph Hellwig wrote: > On Wed, Apr 08, 2020 at 05:22:03PM -0700, Ira Weiny wrote: > > > You mean something like XFS_IDONTCACHE? > > > > > > i.e. the functionality already exists in XFS to selectively evict an > > > inode from cache when the last reference to it is dropped rather > > > than let it go to the LRUs and hang around in memory. > > > > > > That flag can be set when changing the on disk DAX flag, and we can > > > tweak how it works so new cache hits don't clear it (as happens > > > now). Hence the only thing that can prevent eviction are active > > > references. > > > > > > That means we'll still need to stop the application and drop_caches, > > > because we need to close all the files and purge the dentries that > > > hold references to the inode before it can be evicted. > > > > That sounds like a great idea... > > > > Jan? Christoph? > > Sounds ok. Note that we could also pretty trivially lift > XFS_IDONTCACHE to the VFS if we need to apply the same scheme to > ext4. Yes I have been slowing working on ext4 in the background. So lifting XXX_IDONTCACHE to VFS will be part of that series. Thanks, Ira